From: Luca Boccassi <bluca@debian.org>
To: Xiaoyun Li <xiaoyun.li@intel.com>, qabuild@intel.com
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/e1000: fix cannot getting Rx interrupts issue
Date: Fri, 03 Nov 2017 09:57:37 +0000 [thread overview]
Message-ID: <1509703057.9111.1.camel@debian.org> (raw)
In-Reply-To: <1509702009-22759-1-git-send-email-xiaoyun.li@intel.com>
On Fri, 2017-11-03 at 17:40 +0800, Xiaoyun Li wrote:
> When using VFIO and MSIX interrupt mode, cannot get Rx interrupts.
> Because
> the interrupt vectors that are used by VFIO are not enabled. This
> patch
> fixes this issue.
>
> Fixes: c3cd3de0ab50 ("igb: enable Rx queue interrupts for PF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c
> index 003bdf0..dc70d22 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -5387,7 +5387,14 @@ eth_igb_rx_queue_intr_disable(struct
> rte_eth_dev *dev, uint16_t queue_id)
> {
> struct e1000_hw *hw =
> E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> - uint32_t mask = 1 << queue_id;
> + struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> + struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
> + uint32_t vec = E1000_MISC_VEC_ID;
> +
> + if (rte_intr_allow_others(intr_handle))
> + vec = E1000_RX_VEC_START;
> +
> + uint32_t mask = 1 << (queue_id + vec);
>
> E1000_WRITE_REG(hw, E1000_EIMC, mask);
> E1000_WRITE_FLUSH(hw);
> @@ -5402,7 +5409,12 @@ eth_igb_rx_queue_intr_enable(struct
> rte_eth_dev *dev, uint16_t queue_id)
> E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
> - uint32_t mask = 1 << queue_id;
> + uint32_t vec = E1000_MISC_VEC_ID;
> +
> + if (rte_intr_allow_others(intr_handle))
> + vec = E1000_RX_VEC_START;
> +
> + uint32_t mask = 1 << (queue_id + vec);
> uint32_t regval;
>
> regval = E1000_READ_REG(hw, E1000_EIMS);
Hi,
Has this fix, or a version of this fix, being accepted into dpdk/master
? I did a quick search in the git log but cannot see it.
If it has, it applies to 16.11 with a small change to get the pci_dev
in the "old way", so if you would like it in 16.11.4 and it's accepted
in mainline let me know.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2017-11-03 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 9:40 Xiaoyun Li
2017-11-03 9:57 ` Luca Boccassi [this message]
2017-11-03 11:06 ` Li, Xiaoyun
2017-11-03 11:17 Xiaoyun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509703057.9111.1.camel@debian.org \
--to=bluca@debian.org \
--cc=qabuild@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).