From: Wenzhuo Lu <wenzhuo.lu@intel.com>
To: dev@dpdk.org, wei.guo.simon@gmail.com
Subject: Re: [dpdk-dev] [dpdk-dev, RFC, v2] app/testpmd: add option ring-bind-lcpu to bind Q with CPU
Date: Fri, 5 Jan 2018 10:59:30 +0800 [thread overview]
Message-ID: <1515121170-97960-1-git-send-email-wenzhuo.lu@intel.com> (raw)
In-Reply-To: <1499173284-8270-1-git-send-email-wei.guo.simon@gmail.com>
Hi Simon,
> Currently the rx/tx queue is allocated from the buffer pool on socket of:
> - port's socket if --port-numa-config specified
> - or ring-numa-config setting per port
>
> All the above will "bind" queue to single socket per port configuration.
> But it can actually archieve better performance if one port's queue can
> be spread across multiple NUMA nodes, and the rx/tx queue is allocated
> per lcpu socket.
>
> With this patch, testpmd can utilize the PCI-e bus bandwidth on another
> NUMA nodes. with 64bytes package, When running in PowerPC with Mellanox
> CX-4 card, single port(100G), with 8 cores, fw mode:
> - Without this patch: 52.5Mpps throughput
> - With this patch: 66Mpps throughput
>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index fbe6284..d02059d 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -130,6 +130,11 @@
> "(flag: 1 for RX; 2 for TX; 3 for RX and TX).\n");
> printf(" --socket-num=N: set socket from which all memory is allocated "
> "in NUMA mode.\n");
> + printf(" --ring-bind-lcpu: "
> + "specify TX/RX rings will be allocated on local socket of lcpu."
> + "It will overrridden ring-numa-config or port-numa-config if success."
> + "If local ring buffer is unavailable, it will use --ring-numa-config or port-numa-config instead."
> + "It allows one port binds to multiple NUMA nodes.\n");
I think it's a good patch to give the APP an example about how to choose the appropriate core.
Just have some concern about the priority. Maybe ring-numa-config and port-numa-config should have higher priority.
Becuase if APP assigned the specific socket by some purpose, it's not good to overwrite it silently.
> printf(" --mbuf-size=N: set the data size of mbuf to N bytes.\n");
> printf(" --total-num-mbufs=N: set the number of mbufs to be allocated "
> "in mbuf pools.\n");
prev parent reply other threads:[~2018-01-05 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 13:01 [dpdk-dev] [RFC PATCH " wei.guo.simon
2018-01-05 2:59 ` Wenzhuo Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515121170-97960-1-git-send-email-wenzhuo.lu@intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).