From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
To: pbhagavatula@caviumnetworks.com
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
nipun.gupta@nxp.com, hemant.agrawal@nxp.com
Subject: [dpdk-dev] [PATCH v6 00/23] eventtimer: introduce event timer adapter
Date: Wed, 10 Jan 2018 18:20:51 -0600 [thread overview]
Message-ID: <1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com> (raw)
In-Reply-To: <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com>
This patch set adds an initial implementation of the software driver
for the event timer adapter library, adds some unit tests, and adds
documentation. More testing is needed, but I'd like to get feedback on the
current state.
This patch set produces the following checkpatch warning:
"macro with flow control". I have left the macros in since such usage seems
common in DPDK.
The tests also depend on the following patch to pass:
http://dpdk.org/ml/archives/dev/2018-January/085209.html
v6
- Addressed comments on previous versin from Jerin:
- Added RTE_EVENT_TIMER_CANCELED event timer state back in
- remove check for started adapter in timer arm/cancel functions
- reuse CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG instead of adding new config option
- Added initial version of software driver implementation
- Added stats APIs
- Added API to retrieve adapter service ID
- Added API to initialize event timer
- Added entry to Programmer's Guide in documentation
- Added new unit tests to auto-test
v5
- Addressed comments on previous version from Pavan:
- renamed rte_event_timer_adapter_driver.h to rte_event_timer_adapter_pmd.h
- moved contents of sw_event_timer_adapter.c into rte_event_timer_adapter.c
- added flags parameter to timer_adapter_caps_get() call
- added DEBUG config variable to conditionally compile run-time checks on
datapath
- fixed license text and file description
- Also added a config variable to enable/disable compilation of event timer
adapter - feedback on whether this is desirable is appreciated
v4
- Split changes into multiple patches for easier review
v3
- Reworked allocation and ops organization in common code based on feedback
received from Jerin and Pavan. This will allow fast-path function pointers to
be dereferenced with one level of indirection with pointers valid in primary
and secondary processes.
- Moved default software implementation from sw_evdev directory to eventdev
library directory, which will allow it to be used by any eventdev PMD as an
alternative to providing its own definitions.
- Reverted occurrences of id back to pointer to adapter struct in library API
- Added rte_event_timer_adapter_lookup() function back in
v2
- Added ops structure and stubbed out plugin for SW impl
- Added unit test stubs
- Replaced occurrences of "wheel" in API with "adapter"
- Replaced occurrences of pointer to struct rte_event_timer_adapter with ids
- Removed rte_event_timer_adapter_lookup() function
- Replaced RTE_EVENT_TIMER_SUCCESS_{ARM,CANCEL} states with
RTE_EVENT_TIMER_ARMED
Erik Gabriel Carrillo (23):
eventtimer: add event timer adapter API
eventtimer: add common code
eventtimer: add default software driver stub
test: add event timer adapter auto-test
eventtimer: add adapter allocation definitions
test: exercise event timer adapter allocation functions
eventtimer: add adapter get info function definition
eventtimer: add adapter start/stop definitions
eventtimer: add API to get service id
eventtimer: remove service id entry from info structure
test: exercise event timer adapter start/stop functions
eventtimer: add event timer arm/cancel function definitions
eventtimer: add adapter service definition
eventtimer: add event timer initializer function
eventtimer: add buffering of timer expiry events
eventtimer: add stats to API
eventtimer: add support for single-producer put mode
eventtimer: add non-blocking mode for event timer operations
test: exercise event timer arm and expiry
maintainers: add event timer adapter section
doc: add event timer adapter to API index
doc: add event timer adapter section to programmer's guide
doc: add event timer adapter to release notes
MAINTAINERS | 6 +
doc/api/doxy-api-index.md | 1 +
doc/guides/prog_guide/event_timer_adapter.rst | 301 ++++++
doc/guides/prog_guide/index.rst | 1 +
doc/guides/rel_notes/release_18_02.rst | 6 +
drivers/event/sw/sw_evdev.c | 18 +
lib/Makefile | 2 +-
lib/librte_eventdev/Makefile | 5 +-
lib/librte_eventdev/rte_event_timer_adapter.c | 1147 +++++++++++++++++++++
lib/librte_eventdev/rte_event_timer_adapter.h | 651 ++++++++++++
lib/librte_eventdev/rte_event_timer_adapter_pmd.h | 174 ++++
lib/librte_eventdev/rte_eventdev.h | 7 +-
lib/librte_eventdev/rte_eventdev_pmd.h | 35 +
lib/librte_eventdev/rte_eventdev_version.map | 19 +-
mk/rte.app.mk | 2 +-
test/test/Makefile | 1 +
test/test/test_event_timer_adapter.c | 446 ++++++++
17 files changed, 2816 insertions(+), 6 deletions(-)
create mode 100644 doc/guides/prog_guide/event_timer_adapter.rst
create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.c
create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.h
create mode 100644 lib/librte_eventdev/rte_event_timer_adapter_pmd.h
create mode 100644 test/test/test_event_timer_adapter.c
--
2.6.4
next prev parent reply other threads:[~2018-01-11 0:21 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511890148-22295-1-git-send-email-erik.g.carrillo@intel.com>
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 0/5] " Erik Gabriel Carrillo
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 1/5] " Erik Gabriel Carrillo
2017-12-06 15:17 ` Jerin Jacob
2017-12-06 16:23 ` Carrillo, Erik G
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 2/5] eventtimer: add common code Erik Gabriel Carrillo
2017-12-06 15:35 ` Jerin Jacob
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 3/5] eventtimer: add config variable for adapter Erik Gabriel Carrillo
2017-12-06 15:41 ` Jerin Jacob
2017-12-06 20:01 ` Carrillo, Erik G
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 4/5] eventtimer: add default software implementation stub Erik Gabriel Carrillo
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 5/5] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-01-11 0:20 ` Erik Gabriel Carrillo [this message]
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 01/23] eventtimer: add event timer adapter API Erik Gabriel Carrillo
2018-01-11 11:10 ` Pavan Nikhilesh
2018-01-11 16:56 ` Carrillo, Erik G
2018-01-11 17:31 ` Pavan Nikhilesh
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 02/23] eventtimer: add common code Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 03/23] eventtimer: add default software driver stub Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 04/23] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 05/23] eventtimer: add adapter allocation definitions Erik Gabriel Carrillo
2018-01-11 11:18 ` Pavan Nikhilesh
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 06/23] test: exercise event timer adapter allocation functions Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 07/23] eventtimer: add adapter get info function definition Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 08/23] eventtimer: add adapter start/stop definitions Erik Gabriel Carrillo
2018-01-11 17:28 ` Pavan Nikhilesh
2018-01-18 23:57 ` Carrillo, Erik G
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 09/23] eventtimer: add API to get service id Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 10/23] eventtimer: remove service id entry from info structure Erik Gabriel Carrillo
2018-01-11 11:34 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 11/23] test: exercise event timer adapter start/stop functions Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 12/23] eventtimer: add event timer arm/cancel function definitions Erik Gabriel Carrillo
2018-01-11 11:38 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 13/23] eventtimer: add adapter service definition Erik Gabriel Carrillo
2018-01-11 12:03 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 14/23] eventtimer: add event timer initializer function Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 15/23] eventtimer: add buffering of timer expiry events Erik Gabriel Carrillo
2018-01-11 12:18 ` Pavan Nikhilesh
2018-01-18 23:07 ` Carrillo, Erik G
2018-01-20 8:55 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 16/23] eventtimer: add stats to API Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 17/23] eventtimer: add support for single-producer put mode Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 18/23] eventtimer: add non-blocking mode for event timer operations Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 19/23] test: exercise event timer arm and expiry Erik Gabriel Carrillo
2018-01-11 12:26 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 20/23] maintainers: add event timer adapter section Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 21/23] doc: add event timer adapter to API index Erik Gabriel Carrillo
2018-01-12 11:12 ` Kovacevic, Marko
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 22/23] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-01-11 15:26 ` Kovacevic, Marko
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 23/23] doc: add event timer adapter to release notes Erik Gabriel Carrillo
2018-01-12 10:48 ` Kovacevic, Marko
2018-03-08 21:53 ` [dpdk-dev] [PATCH v7 0/7] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 1/7] eventtimer: add event timer adapter API Erik Gabriel Carrillo
2018-03-12 7:53 ` Jerin Jacob
2018-03-12 16:22 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 2/7] eventtimer: add common code Erik Gabriel Carrillo
2018-03-12 8:11 ` Jerin Jacob
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 3/7] eventtimer: add default software driver Erik Gabriel Carrillo
2018-03-12 8:45 ` Jerin Jacob
2018-03-12 21:20 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 4/7] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-03-14 12:52 ` Pavan Nikhilesh
2018-03-14 21:42 ` Carrillo, Erik G
2018-03-14 13:31 ` Pavan Nikhilesh
2018-03-14 21:40 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 6/7] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-03-12 11:21 ` Jerin Jacob
2018-03-12 22:02 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 7/7] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-03-12 11:28 ` Jerin Jacob
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 0/9] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 1/9] " Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-02 8:12 ` Jerin Jacob
2018-04-02 9:16 ` Hemant Agrawal
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-02 8:42 ` Jerin Jacob
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-03-30 15:48 ` Bhagavatula, Pavan
2018-03-30 18:47 ` Carrillo, Erik G
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 1/9] " Erik Gabriel Carrillo
2018-04-02 23:25 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-02 23:27 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-02 23:35 ` Jerin Jacob
2018-04-03 18:38 ` Carrillo, Erik G
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-02 23:36 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-03 9:59 ` Pavan Nikhilesh
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-03 9:52 ` Pavan Nikhilesh
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-03 0:00 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-02 23:42 ` Jerin Jacob
2018-04-02 23:19 ` [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter Jerin Jacob
2018-04-03 14:09 ` Carrillo, Erik G
2018-04-03 14:15 ` Jerin Jacob
2018-04-03 18:32 ` Carrillo, Erik G
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 " Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 1/9] " Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-04 16:50 ` Pavan Nikhilesh
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-04 16:51 ` Pavan Nikhilesh
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-04 2:31 ` [dpdk-dev] [PATCH v10 0/9] eventtimer: introduce event timer adapter Jerin Jacob
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 " Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 1/9] " Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-05 3:31 ` [dpdk-dev] [PATCH v11 0/9] eventtimer: introduce event timer adapter Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com \
--to=erik.g.carrillo@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).