From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Matthias Bartelt <mail@mbartelt.de>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix warnings if DPDK is used with C++1x: Format macro constants for fixed width integer types need a space after the preceding string literal.
Date: Tue, 21 Oct 2014 11:17:20 +0200 [thread overview]
Message-ID: <1516000.auUSWjmSzW@xps13> (raw)
In-Reply-To: <1413880725-9682-1-git-send-email-mail@mbartelt.de>
Hi,
Thank you for the patch. Not a lot of people use DPDK with C++, so we probably
need some fixes.
Please, could you send a v2 of this patch with a shorter title, an explanation
in commit log and a signed-off?
Guidelines are explained here:
http://dpdk.org/dev#send
2014-10-21 10:38, Matthias Bartelt:
> From: Matthias Bartelt <mb@mb-laptop.(none)>
You need to configure your email address in .gitconfig to remove this.
--
Thomas
prev parent reply other threads:[~2014-10-21 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:38 Matthias Bartelt
2014-10-21 9:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516000.auUSWjmSzW@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=mail@mbartelt.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).