DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Shahaf Shuler <shahafs@mellanox.com>
Subject: [dpdk-dev] [PATCH v4 0/6] net/sfc: convert to the new offload API
Date: Thu, 18 Jan 2018 09:44:25 +0000	[thread overview]
Message-ID: <1516268671-29894-1-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com>

May be it is too late to suggest a new API functions to ethdev,
but hopefully if the idea is accepted, it could be applied in the
current release cycle since these functions are trivial.

I'm not sure that rte_ethdev_version.map is updated correctly
since EXPERIMENTAL tag is present and I don't understand how it
should be handled.

In general for the transition period from old offload API to the
new one it would be useful to convert Tx offloads to/from txq_flags
in rte_eth_dev_info_get() for default_txconf and
rte_eth_tx_queue_info_get(). Unfortunately it was lost during
new offload API patches review. However, it would require testing
for all network PMDs and we decided to follow more conservative
approach and kept code to fill in txq_flags which should be simply
removed when txq_flags are removed.

Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>

---

v4:
 - add symbols to map file in aphabetical order
 - add dots in ethdev function descriptions (seems to be more common
   for rte_ethdev.h file)

v3:
 - add Reviewed-by lost in previous version

v2:
 - make new ethdev API experimentatal (map file and function comment)
 - use space instead of TAB after #define for RTE_?X_OFFLOAD_BIT2STR


Ivan Malov (6):
  ethdev: add a function to look up Rx offload names
  ethdev: add a function to look up Tx offload names
  net/sfc: factor out function to report Rx capabilities
  net/sfc: convert to the new Rx offload API
  net/sfc: factor out function to report Tx capabilities
  net/sfc: convert to the new Tx offload API

 drivers/net/sfc/sfc_dp_tx.h             |   2 +
 drivers/net/sfc/sfc_ethdev.c            |  58 ++++++----
 drivers/net/sfc/sfc_port.c              |   5 +-
 drivers/net/sfc/sfc_rx.c                | 128 +++++++++++++++------
 drivers/net/sfc/sfc_rx.h                |   3 +
 drivers/net/sfc/sfc_tx.c                | 194 +++++++++++++++++++++-----------
 drivers/net/sfc/sfc_tx.h                |   4 +
 lib/librte_ether/rte_ethdev.c           |  87 ++++++++++++++
 lib/librte_ether/rte_ethdev.h           |  36 ++++++
 lib/librte_ether/rte_ethdev_version.map |   2 +
 10 files changed, 397 insertions(+), 122 deletions(-)

-- 
2.7.4

  parent reply	other threads:[~2018-01-18  9:44 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  8:12 [dpdk-dev] [PATCH " Andrew Rybchenko
2018-01-11  8:12 ` [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-17 16:55   ` Ferruh Yigit
2018-01-17 17:06     ` Thomas Monjalon
2018-01-17 17:33   ` Thomas Monjalon
2018-01-18  6:32     ` Shahaf Shuler
2018-01-18  7:16     ` Andrew Rybchenko
2018-01-18  7:52       ` Andrew Rybchenko
2018-01-18  9:24         ` Thomas Monjalon
2018-01-11  8:12 ` [dpdk-dev] [PATCH 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-11  8:12 ` [dpdk-dev] [PATCH 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-11  8:12 ` [dpdk-dev] [PATCH 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-11  8:12 ` [dpdk-dev] [PATCH 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-11  8:12 ` [dpdk-dev] [PATCH 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-17 16:55 ` [dpdk-dev] [PATCH 0/6] net/sfc: convert to the new " Ferruh Yigit
2018-01-18  7:02 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18  7:02   ` [dpdk-dev] [PATCH v2 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18  7:07 ` [dpdk-dev] [PATCH v3 0/6] net/sfc: convert to the new " Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18  9:26     ` Thomas Monjalon
2018-01-18  9:47       ` Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18  7:07   ` [dpdk-dev] [PATCH v3 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18  9:44 ` Andrew Rybchenko [this message]
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18 10:29     ` Thomas Monjalon
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18 10:30     ` Thomas Monjalon
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18  9:44   ` [dpdk-dev] [PATCH v4 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18 15:40   ` [dpdk-dev] [PATCH v4 0/6] net/sfc: convert to the new " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516268671-29894-1-git-send-email-arybchenko@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).