From: Wenzhuo Lu <wenzhuo.lu@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling
Date: Wed, 24 Jan 2018 16:16:52 +0800 [thread overview]
Message-ID: <1516781813-50818-4-git-send-email-wenzhuo.lu@intel.com> (raw)
In-Reply-To: <1516781813-50818-1-git-send-email-wenzhuo.lu@intel.com>
When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.
Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/e1000/igb_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 077e094..15347df 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -3295,7 +3295,8 @@ static int eth_igbvf_link_update(struct e1000_hw *hw)
}
/* check and configure queue intr-vector mapping */
- if (dev->data->dev_conf.intr_conf.rxq != 0) {
+ if (rte_intr_cap_multiple(intr_handle) &&
+ dev->data->dev_conf.intr_conf.rxq) {
intr_vector = dev->data->nb_rx_queues;
ret = rte_intr_efd_enable(intr_handle, intr_vector);
if (ret)
--
1.9.3
next prev parent reply other threads:[~2018-01-24 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1516757925-3746-1-git-send-email-wenzhuo.lu@intel.com>
2018-01-24 1:38 ` [dpdk-stable] [PATCH 1/4] net/i40e: " Wenzhuo Lu
2018-01-24 1:38 ` [dpdk-stable] [PATCH 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-24 1:38 ` [dpdk-stable] [PATCH 3/4] net/e1000: " Wenzhuo Lu
[not found] ` <1516781813-50818-1-git-send-email-wenzhuo.lu@intel.com>
2018-01-24 8:16 ` [dpdk-stable] [PATCH v2 1/4] net/i40e: " Wenzhuo Lu
2018-01-26 15:32 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
2018-01-26 15:40 ` Zhang, Helin
2018-01-24 8:16 ` [dpdk-stable] [PATCH v2 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-26 15:32 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
2018-01-26 15:40 ` Zhang, Helin
2018-01-24 8:16 ` Wenzhuo Lu [this message]
2018-01-26 15:33 ` [dpdk-stable] [dpdk-dev] [PATCH v2 3/4] net/e1000: " Zhang, Helin
2018-01-26 15:41 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516781813-50818-4-git-send-email-wenzhuo.lu@intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).