From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vlad Zolotarov <vladz@cloudius-systems.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD
Date: Thu, 07 May 2015 19:25:02 +0200 [thread overview]
Message-ID: <1517243.9KvEt0E09c@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725821422676@irsmsx105.ger.corp.intel.com>
> > This series includes:
> > - Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b9226de:
> > files in librte_pmd_ixgbe/ixgbe/ are shared with FreeBSD and AFAIU should not
> > be changed unless the change is pushed into the FreeBSD tree first.
> > - Remove unused rsc_en field in ixgbe_rx_queue struct.
> > Thanks to Shiweixian <shiweixian@huawei.com> for pointing this out.
> > - Kill the non-vector scattered Rx callback and use an appropriate LRO callback
> > instead. This is possible because work against HW in both LRO and scattered RX
> > cases is the same. Note that this patch touches the ixgbevf PMD as well.
> > - Use LRO bulk callback when scattered (non-LRO) Rx is requested and parameters
> > allow bulk allocation.
> >
> > Note that this series is meant to cleanup the PF PMD and is a follow up series for my
> > previous patches. Although VF PMD is slightly modified here too this series doesn't mean
> > to fix/add new functionality to it. VF PMD should be patched in the similar way I've
> > patched PF PMD in my previous series in order to fix the same issues that were fixed in
> > the PF PMD and in order to enable LRO and scattered Rx with bulk allocations.
> >
> > New in v2:
> > - Rename RSC-specific structures to "Scattered Rx" derivatives.
> > - Always allocate Scattered Rx ring.
> >
> > Vlad Zolotarov (5):
> > ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter
> > ixgbe: ixgbe_rx_queue: remove unused rsc_en field
> > ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx
> > ixgbe: Kill ixgbe_recv_scattered_pkts()
> > ixgbe: Add support for scattered Rx with bulk allocation.
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Thanks a lot for doing it.
Applied, thanks
prev parent reply other threads:[~2015-05-07 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 8:38 Vlad Zolotarov
2015-04-29 8:38 ` [dpdk-dev] [PATCH v2 1/5] ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter Vlad Zolotarov
2015-04-29 8:38 ` [dpdk-dev] [PATCH v2 2/5] ixgbe: ixgbe_rx_queue: remove unused rsc_en field Vlad Zolotarov
2015-04-29 8:38 ` [dpdk-dev] [PATCH v2 3/5] ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx Vlad Zolotarov
2015-04-29 8:38 ` [dpdk-dev] [PATCH v2 4/5] ixgbe: Kill ixgbe_recv_scattered_pkts() Vlad Zolotarov
2015-04-29 8:38 ` [dpdk-dev] [PATCH v2 5/5] ixgbe: Add support for scattered Rx with bulk allocation Vlad Zolotarov
2015-04-29 11:25 ` [dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD Ananyev, Konstantin
2015-05-07 17:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517243.9KvEt0E09c@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=vladz@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).