DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v6 04/13] vhost: rxtx: prepare work for multiple queue support
Date: Tue, 20 Oct 2015 09:24:09 +0200	[thread overview]
Message-ID: <15234883.iyK6Fa9SCL@xps13> (raw)
In-Reply-To: <20151020071004.GT3115@yliu-dev.sh.intel.com>

2015-10-20 15:10, Yuanhan Liu:
> On Tue, Oct 20, 2015 at 08:57:52AM +0200, Thomas Monjalon wrote:
> > > -	if (unlikely(queue_id != VIRTIO_RXQ)) {
> > > -		LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> > > +	if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->virt_qp_nb))) {
> > > +		RTE_LOG(ERR, VHOST_DATA,
> > > +			"%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> > > +			__func__, dev->device_fh, queue_id);
> > [...]
> > > -	if (unlikely(queue_id != VIRTIO_RXQ)) {
> > > -		LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> > > +	if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->virt_qp_nb))) {
> > > +		RTE_LOG(ERR, VHOST_DATA,
> > > +			"%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> > > +			__func__, dev->device_fh, queue_id);
> > > +		return 0;
> > [...]
> > > -	if (unlikely(queue_id != VIRTIO_TXQ)) {
> > > -		LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> > > +	if (unlikely(!is_valid_virt_queue_idx(queue_id, 1, dev->virt_qp_nb))) {
> > > +		RTE_LOG(ERR, VHOST_DATA,
> > > +			"%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> > > +			__func__, dev->device_fh, queue_id);
> > 
> > Why not use the log macros in drivers/net/virtio/virtio_logs.h?
> 
> Do you mean I should keep using LOG_DEBUG instead?

No you can use the error level.
Actually I was checking the logs in virtio which use some log wrapper to keep
some consistency. But the vhost code doesn't seem to have such policy.
So you are free :)
But I would say you should avoid changing the log format if does not comply
with the rest of the library. The __func__ macro is not really used.
Maybe Huawei could give a general policy for vhost logs (having a general
consistency in all DPDK libs is better).

  reply	other threads:[~2015-10-20  7:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09  5:45 [dpdk-dev] [PATCH v6 00/13] vhost-user multiple queues enabling Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 01/13] vhost-user: add protocol features support Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 02/13] vhost-user: add VHOST_USER_GET_QUEUE_NUM message Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 03/13] vhost: vring queue setup for multiple queue support Yuanhan Liu
2015-10-20  6:49   ` Thomas Monjalon
2015-10-20  6:56     ` Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 04/13] vhost: rxtx: prepare work " Yuanhan Liu
2015-10-20  6:57   ` Thomas Monjalon
2015-10-20  7:10     ` Yuanhan Liu
2015-10-20  7:24       ` Thomas Monjalon [this message]
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 05/13] vhost-user: handle VHOST_USER_RESET_OWNER correctly Yuanhan Liu
2015-10-20  7:03   ` Thomas Monjalon
2015-10-20  7:14     ` Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config correctly Yuanhan Liu
2015-10-20  7:07   ` Thomas Monjalon
2015-10-20  7:23     ` Yuanhan Liu
2015-10-20  7:27       ` Thomas Monjalon
2015-10-20  8:00         ` Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 07/13] vhost-user: enable vhost-user multiple queue Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 08/13] vhost: add VHOST_USER_SET_VRING_ENABLE message Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 09/13] vhost: add API bind a virtq to a specific core Yuanhan Liu
     [not found]   ` <C37D651A908B024F974696C65296B57B4B12E8D3@SHSMSX101.ccr.corp.intel.com>
2015-10-20  6:25     ` Yuanhan Liu
2015-10-20  7:17       ` Thomas Monjalon
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment Yuanhan Liu
2015-10-20  7:46   ` Thomas Monjalon
     [not found]   ` <2601191342CEEE43887BDE71AB97725836AB3299@irsmsx105.ger.corp.intel.com>
2015-10-21 13:01     ` Yuanhan Liu
2015-10-21 13:03       ` Ananyev, Konstantin
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 11/13] examples/vhost: demonstrate the usage of vhost mq feature Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 12/13] examples/vhost: add per queue stats Yuanhan Liu
2015-10-09  5:46 ` [dpdk-dev] [PATCH v6 13/13] doc: update release note for vhost-user mq support Yuanhan Liu
2015-10-09 13:45 ` [dpdk-dev] [PATCH v6 00/13] vhost-user multiple queues enabling Marcel Apfelbaum
2015-10-19 13:16 ` Flavio Leitner
2015-10-20 10:39 ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15234883.iyK6Fa9SCL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).