From: Jianfeng Tan <jianfeng.tan@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, Jianfeng Tan <jianfeng.tan@intel.com>
Subject: [dpdk-dev] [PATCH v4 0/5] allow procinfo and pdump on eth vdev
Date: Fri, 20 Apr 2018 16:57:38 +0000 [thread overview]
Message-ID: <1524243463-143438-1-git-send-email-jianfeng.tan@intel.com> (raw)
In-Reply-To: <1520177405-59091-1-git-send-email-jianfeng.tan@intel.com>
v4:
- Change the lock code style as suggested by Anatoly.
- Add function note as suggested by Anatoly.
v3:
- Update doc.
- Rebase on master.
v2:
- Add spinlock for vdev device list as suggested by Anatoly.
- Add ring, cxgbe and remove the free in each PMDs as suggested by Matan.
- Rebase on master.
As we know, we have below limitations in vdev:
- dpdk-procinfo cannot get the stats of (most) vdev in primary process;
- dpdk-pdump cannot dump the packets for (most) vdev in primary process;
- secondary process cannot use (most) vdev in primary process.
The very first reason is that the secondary process actually does not know
the existence of those vdevs as vdevs are chained on a linked list, and
not shareable to secondary.
In this patchset, we would like to propose a vdev sharing model like this:
- As a secondary process boots, all devices (including vdev) in primary
will be automatically shared. After both primary and secondary process
booted,
- Device add/remove in primary will be translated to device hog
plug/unplug event in secondary processes. (TODO)
- Device add in secondary
* If that kind of device support multi-process, the secondary will
request the primary to probe the device and the primary to share
it to the secondary. It's not necessary to have secondary-private
device in this case. (TODO)
* If that kind of device does not support multi-process, the secondary
will probe the device by itself, and the port id is shared among
all primary/secondary processes.
This patchset don't:
- provide secondary data path (Rx/Tx) support for each specific vdev.
How to test:
Step 0: start testpmd with a vhost port and a VM connected to it.
Step 1: try using dpdk-procinfo to get the stats.
$(dpdk-procinfo) --log-level=8 --no-pci -- --stats
Step 2: try using dpdk-pdump to dump the packets.
$(dpdk-pdump) -- --pdump 'port=0,queue=*,rx-dev=/tmp/rx.pcap'
Jianfeng Tan (5):
eal: bring forward multi-process channel init
bus/vdev: add lock on vdev device list
bus/vdev: bus scan by multi-process channel
drivers/net: not use private eth dev data
drivers/net: share vdev data to secondary process
doc/guides/rel_notes/release_18_05.rst | 5 +
drivers/bus/vdev/Makefile | 1 +
drivers/bus/vdev/vdev.c | 193 ++++++++++++++++++++++++++----
drivers/net/af_packet/rte_eth_af_packet.c | 43 +++----
drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++
drivers/net/cxgbe/cxgbe_main.c | 1 -
drivers/net/failsafe/failsafe.c | 14 +++
drivers/net/kni/rte_eth_kni.c | 26 ++--
drivers/net/null/rte_eth_null.c | 32 ++---
drivers/net/octeontx/octeontx_ethdev.c | 29 +++--
drivers/net/pcap/rte_eth_pcap.c | 32 ++---
drivers/net/ring/rte_eth_ring.c | 17 +--
drivers/net/softnic/rte_eth_softnic.c | 19 ++-
drivers/net/tap/rte_eth_tap.c | 24 ++--
drivers/net/vhost/rte_eth_vhost.c | 36 +++---
lib/librte_eal/bsdapp/eal/eal.c | 23 ++--
lib/librte_eal/linuxapp/eal/eal.c | 23 ++--
17 files changed, 360 insertions(+), 171 deletions(-)
--
2.7.4
next prev parent reply other threads:[~2018-04-20 16:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 15:30 [dpdk-dev] [PATCH 0/4] " Jianfeng Tan
2018-03-04 15:30 ` [dpdk-dev] [PATCH 1/4] eal: bring forward multi-process channel init Jianfeng Tan
2018-03-04 15:30 ` [dpdk-dev] [PATCH 2/4] bus/vdev: bus scan by multi-process channel Jianfeng Tan
2018-03-05 9:36 ` Burakov, Anatoly
2018-03-06 0:50 ` Tan, Jianfeng
2018-03-07 14:00 ` Burakov, Anatoly
2018-03-12 3:22 ` Tan, Jianfeng
2018-03-04 15:30 ` [dpdk-dev] [PATCH 3/4] drivers/net: do not allocate rte_eth_dev_data privately Jianfeng Tan
2018-03-06 6:07 ` Matan Azrad
2018-03-06 8:55 ` Tan, Jianfeng
2018-03-07 6:00 ` Matan Azrad
2018-03-07 6:10 ` Matan Azrad
2018-03-12 3:40 ` Tan, Jianfeng
2018-03-04 15:30 ` [dpdk-dev] [PATCH 4/4] drivers/net: share vdev data to secondary process Jianfeng Tan
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 0/5] allow procinfo and pdump on eth vdev Jianfeng Tan
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 1/5] eal: bring forward multi-process channel init Jianfeng Tan
2018-04-20 8:16 ` Burakov, Anatoly
2018-04-20 14:08 ` Tan, Jianfeng
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 2/5] bus/vdev: add lock on vdev device list Jianfeng Tan
2018-04-20 8:26 ` Burakov, Anatoly
2018-04-20 14:19 ` Tan, Jianfeng
2018-04-20 15:16 ` Burakov, Anatoly
2018-04-20 15:23 ` Tan, Jianfeng
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 3/5] bus/vdev: bus scan by multi-process channel Jianfeng Tan
2018-04-20 8:41 ` Burakov, Anatoly
2018-04-20 14:28 ` Tan, Jianfeng
2018-04-20 15:19 ` Burakov, Anatoly
2018-04-20 15:32 ` Tan, Jianfeng
2018-04-20 15:39 ` Burakov, Anatoly
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 4/5] drivers/net: not use private eth dev data Jianfeng Tan
2018-04-19 16:50 ` [dpdk-dev] [PATCH v3 5/5] drivers/net: share vdev data to secondary process Jianfeng Tan
2018-04-20 16:57 ` Jianfeng Tan [this message]
2018-04-20 16:57 ` [dpdk-dev] [PATCH v4 1/5] eal: bring forward multi-process channel init Jianfeng Tan
2018-04-20 16:57 ` [dpdk-dev] [PATCH v4 2/5] bus/vdev: add lock on vdev device list Jianfeng Tan
2018-04-23 9:47 ` Burakov, Anatoly
2018-04-20 16:57 ` [dpdk-dev] [PATCH v4 3/5] bus/vdev: bus scan by multi-process channel Jianfeng Tan
2018-04-23 9:54 ` Burakov, Anatoly
2018-04-24 5:22 ` Tan, Jianfeng
2018-04-20 16:57 ` [dpdk-dev] [PATCH v4 4/5] drivers/net: not use private eth dev data Jianfeng Tan
2018-04-20 16:57 ` [dpdk-dev] [PATCH v4 5/5] drivers/net: share vdev data to secondary process Jianfeng Tan
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 0/5] allow procinfo and pdump on eth vdev Jianfeng Tan
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 1/5] eal: bring forward multi-process channel init Jianfeng Tan
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 2/5] bus/vdev: add lock on vdev device list Jianfeng Tan
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 3/5] bus/vdev: bus scan by multi-process channel Jianfeng Tan
2018-04-24 10:09 ` Thomas Monjalon
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 4/5] drivers/net: not use private eth dev data Jianfeng Tan
2018-04-24 5:51 ` [dpdk-dev] [PATCH v5 5/5] drivers/net: share vdev data to secondary process Jianfeng Tan
2018-04-24 10:32 ` [dpdk-dev] [PATCH v5 0/5] allow procinfo and pdump on eth vdev Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524243463-143438-1-git-send-email-jianfeng.tan@intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).