From: Luca Boccassi <bluca@debian.org>
To: xiangxia.m.yue@gmail.com, maxime.coquelin@redhat.com,
jianfeng.tan@intel.com, yliu@fridaylinux.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset
Date: Mon, 30 Apr 2018 14:44:43 +0100 [thread overview]
Message-ID: <1525095883.23337.21.camel@debian.org> (raw)
In-Reply-To: <1524840538-3941-1-git-send-email-xiangxia.m.yue@gmail.com>
On Fri, 2018-04-27 at 07:48 -0700, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When qemu close the unix socket fd of the vhostuser as a
> server, and then immediately delete the vhostuser port on
> openvswitch. There will be a deadlock.
>
> A thread (fdset event thread): B thread:
> 1. fdset_event_dispatch rte_vhost_driver_unregister
> 2. set the fd busy to 1. lock vsocket->conn_mutex
> 3. vhost_user_read_cb fdset_del waits busy changed to
> 0.
> 4. vhost peer closed, remove the
> conn from vsocket->conn_list:
> lock vsocket->conn_mutex
>
> 5. set the fd busy to 0
>
> Fixes: 65388b43 ("vhost: fix fd leaks for vhost-user server mode")
> Cc: stable@dpdk.org
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Hi, has a version of this series been merged into mainline?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-04-30 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:48 xiangxia.m.yue
2018-04-27 14:48 ` [dpdk-stable] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed xiangxia.m.yue
2018-04-30 13:44 ` Luca Boccassi [this message]
2018-04-30 13:46 ` [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset Maxime Coquelin
2018-04-27 15:19 xiangxia.m.yue
2018-05-04 13:00 ` Maxime Coquelin
2018-05-04 15:11 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525095883.23337.21.camel@debian.org \
--to=bluca@debian.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).