From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org, yliu@fridaylinux.org
Subject: Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches
Date: Thu, 17 May 2018 14:54:03 +0100 [thread overview]
Message-ID: <1526565243.23337.133.camel@debian.org> (raw)
In-Reply-To: <1744032.J4TBba0YLV@xps>
On Thu, 2018-05-17 at 15:12 +0200, Thomas Monjalon wrote:
> 16/05/2018 19:03, Luca Boccassi:
> > On Wed, 2018-05-16 at 16:19 +0100, Kevin Traynor wrote:
> > > On 05/16/2018 03:31 PM, luca.boccassi@gmail.com wrote:
> > > > From: Luca Boccassi <bluca@debian.org>
> > > >
> > > > We have many stable branches being maintaned at the same time,
> > > > and
> > >
> > > typo
> > >
> > > > sometimes it's not clear which branch a patch is being
> > > > backported
> > > > for.
> > > > Note in the guidelines that it should be specified via the
> > > > cover
> > > > letter,
> > > > annotation or using --subject-prefix.
> > > > Also note to send only to stable@dpdk.org, not dev@dpdk.org.
> > > >
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > ---
> > > > doc/guides/contributing/patches.rst | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/doc/guides/contributing/patches.rst
> > > > b/doc/guides/contributing/patches.rst
> > > > index 2287835f9..1dc623a23 100644
> > > > --- a/doc/guides/contributing/patches.rst
> > > > +++ b/doc/guides/contributing/patches.rst
> > > > @@ -450,6 +450,14 @@ Experienced committers may send patches
> > > > directly with ``git send-email`` without
> > > > The options ``--annotate`` and ``confirm = always`` are
> > > > recommended for checking patches before sending.
> > > >
> > > >
> > > > +Backporting patches for Stable Releases
> > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > +
> > > > +Sometimes a maintainer or contributor wishes, or can be asked,
> > > > to
> > > > send a patch for a stable release rather than mainline. In this
> > > > case the patch(es) should be sent to ``stable@dpdk.org``, not
> > > > to ``
> > > > dev@dpdk.org``.
> > > > +
> > > > +Given that there are multiple stable releases being maintained
> > > > at
> > > > the same time, please specify exactly which branch the patch is
> > > > for
> > > > in the cover letter, in the annotation or using ``git send-
> > > > email --
> > > > subject-prefix='16.11' ...``
> > > > +
> > >
> > > s/branch/branch(es)/
> > >
> > > How about [16.11] instead of '16.11' ?
> >
> > Using --subject-prefix git will already use "[PATCH 16.11]
>
> I think it should be --subject-prefix='PATCH 16.11'
>
> Please wrap the lines after some punctuation signs to avoid really
> long lines
> in the rst file.
Ok, done both in v3.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-05-17 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 14:31 luca.boccassi
2018-05-16 15:19 ` Kevin Traynor
2018-05-16 17:03 ` Luca Boccassi
2018-05-17 13:12 ` Thomas Monjalon
2018-05-17 13:54 ` Luca Boccassi [this message]
2018-05-16 17:05 ` [dpdk-dev] [PATCH v2] " luca.boccassi
2018-05-16 19:45 ` Kevin Traynor
2018-05-17 13:53 ` [dpdk-dev] [PATCH v3] " luca.boccassi
2018-05-25 7:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526565243.23337.133.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).