From: Thomas Monjalon <thomas@monjalon.net>
To: wenzhuo.lu@intel.com, ferruh.yigit@intel.com
Cc: Moti Haimovsky <motih@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: do not enable Rx offloads by default
Date: Mon, 29 Jan 2018 12:52:10 +0100 [thread overview]
Message-ID: <1526570.x4yMYrLSQg@xps> (raw)
In-Reply-To: <1517225598-132061-1-git-send-email-motih@mellanox.com>
29/01/2018 12:33, Moti Haimovsky:
> Removed the hardcoded preconfigured Rx offload configuration from
> testpmd and changed the Rx offload command line parameters from
> disable to enable.
> Testers who wish to use these offloads will now have to explicitly
> write them in the command-line when running testpmd.
>
> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying
> to enable a not supported offload is clearly an error which will cause
> configuration failing.
>
> Considering that testpmd is an application to test the PMD, it should
> not fail on a configuration which was not explicitly requested.
> The behavior of this test application is then turned to an opt-in
> model.
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
This is a very good step in the right direction
because testpmd is a tool app.
So testpmd must not enable anything without explicit user request.
The next step will be to check the offload capabilities
before enabling them.
If a requested capability is not available, it should return
either an error, or a warning.
I want to merge this first patch in 18.02-rc2,
because some drivers (lacking some capabilities) cannot be tested
without explicitly disabling the forced offloads.
next prev parent reply other threads:[~2018-01-29 11:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 8:11 [dpdk-dev] [PATCH] " Moti Haimovsky
2018-01-25 1:11 ` Lu, Wenzhuo
2018-01-25 9:04 ` Thomas Monjalon
2018-01-25 16:01 ` Stephen Hemminger
2018-01-26 7:31 ` Lu, Wenzhuo
2018-01-26 7:49 ` Thomas Monjalon
2018-01-26 7:30 ` Lu, Wenzhuo
2018-01-26 7:48 ` Thomas Monjalon
2018-01-26 8:06 ` Lu, Wenzhuo
2018-01-26 8:35 ` Thomas Monjalon
2018-01-27 18:14 ` Shahaf Shuler
2018-01-29 11:33 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2018-01-29 11:52 ` Thomas Monjalon [this message]
2018-01-30 8:44 ` [dpdk-dev] [PATCH v3] " Moti Haimovsky
2018-01-30 9:00 ` [dpdk-dev] [PATCH v4] " Moti Haimovsky
2018-01-31 3:16 ` Lu, Wenzhuo
2018-01-31 11:55 ` [dpdk-dev] [PATCH v5] " Moti Haimovsky
2018-01-31 16:59 ` [dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx " Moti Haimovsky
2018-01-31 17:19 ` Thomas Monjalon
2018-01-31 17:32 ` [dpdk-dev] [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads Moti Haimovsky
2018-01-31 21:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526570.x4yMYrLSQg@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=motih@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).