From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
hanxueluo@126.com, Huanle Han <hanxueluo@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] pci: fix crash caused by invaild memory write
Date: Tue, 02 May 2017 00:59:43 +0200 [thread overview]
Message-ID: <1531100.1qSifb3cKg@xps> (raw)
In-Reply-To: <20170222023623.GO18844@yliu-dev.sh.intel.com>
22/02/2017 03:36, Yuanhan Liu:
> On Mon, Feb 20, 2017 at 10:04:47PM +0800, hanxueluo@126.com wrote:
> > From: Huanle Han <hanxueluo@gmail.com>
> >
> > rte_eal_dev_detach() didn't remove dev from dev_device_list
> > after free the dev. So the following attached dev wrote to
> > the freed memory (tailq entry of previous dev) in below stack:
> >
> > == Invalid write of size 8
> > == at 0x43A9CE: rte_eal_device_insert (eal_common_dev.c:71)
> > == by 0x42ED9E: pci_scan_one (eal_pci.c:365)
> > == by 0x42EF4D: pci_update_device (eal_pci.c:391)
> > == by 0x437F59: rte_eal_pci_probe_one (eal_common_pci.c:357)
> > == by 0x43AB16: rte_eal_dev_attach (eal_common_dev.c:117)
> > == by 0x45B3AA: rte_eth_dev_attach (rte_ethdev.c:489)
> > == ...
> >
> > Signed-off-by: Huanle Han <hanxueluo@gmail.com>
>
> The two minor nits also apply here, besides that,
>
> Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Nack
The right fix is to remove the functions insert and remove.
The list dev_device_list is not used anymore.
I will make a patch.
next prev parent reply other threads:[~2017-05-01 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 14:04 [dpdk-dev] [PATCH 1/3] net/virtio: fix dev detachable flag hanxueluo
2017-02-20 14:04 ` [dpdk-dev] [PATCH 2/3] net/virtio: fix crash when close virtio dev twice hanxueluo
2017-02-22 2:24 ` Yuanhan Liu
2017-04-28 4:56 ` Yuanhan Liu
2017-02-20 14:04 ` [dpdk-dev] [PATCH 3/3] pci: fix crash caused by invaild memory write hanxueluo
2017-02-22 2:36 ` Yuanhan Liu
2017-05-01 22:59 ` Thomas Monjalon [this message]
2017-02-22 2:34 ` [dpdk-dev] [PATCH 1/3] net/virtio: fix dev detachable flag Yuanhan Liu
2017-04-28 4:58 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531100.1qSifb3cKg@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hanxueluo@126.com \
--cc=hanxueluo@gmail.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).