From: Reshma Pattan <reshma.pattan@intel.com>
To: thomas@monjalon.net, dev@dpdk.org
Cc: anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v4 2/9] autotest: fix invalid code on reports
Date: Tue, 17 Jul 2018 14:15:24 +0100 [thread overview]
Message-ID: <1531833331-18148-3-git-send-email-reshma.pattan@intel.com> (raw)
In-Reply-To: <1531833331-18148-1-git-send-email-reshma.pattan@intel.com>
There are no reports defined for any test, so this codepath was
never triggered, but it's still wrong because it's referencing
variables that aren't there. Fix it by passing target into the
test function, and reference correct log variable.
Fixes: e2cc79b75d9f ("app: rework autotest.py")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
test/test/autotest_runner.py | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index b09b57876..bdc32da5d 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -41,7 +41,7 @@ def wait_prompt(child):
# quite a bit of effort to make it work).
-def run_test_group(cmdline, test_group):
+def run_test_group(cmdline, target, test_group):
results = []
child = None
start_time = time.time()
@@ -128,14 +128,15 @@ def run_test_group(cmdline, test_group):
# make a note when the test was finished
end_time = time.time()
+ log = logfile.getvalue()
+
# append test data to the result tuple
- result += (test["Name"], end_time - start_time,
- logfile.getvalue())
+ result += (test["Name"], end_time - start_time, log)
# call report function, if any defined, and supply it with
# target and complete log for test run
if test["Report"]:
- report = test["Report"](self.target, log)
+ report = test["Report"](target, log)
# append report to results tuple
result += (report,)
@@ -343,6 +344,7 @@ def run_all_tests(self):
for test_group in self.parallel_test_groups:
result = pool.apply_async(run_test_group,
[self.__get_cmdline(test_group),
+ self.target,
test_group])
results.append(result)
@@ -367,7 +369,7 @@ def run_all_tests(self):
# run non_parallel tests. they are run one by one, synchronously
for test_group in self.non_parallel_test_groups:
group_result = run_test_group(
- self.__get_cmdline(test_group), test_group)
+ self.__get_cmdline(test_group), self.target, test_group)
self.__process_results(group_result)
--
2.14.4
next prev parent reply other threads:[~2018-07-17 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1531833331-18148-1-git-send-email-reshma.pattan@intel.com>
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 1/9] autotest: fix printing Reshma Pattan
2018-07-17 13:15 ` Reshma Pattan [this message]
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 5/9] autotest: improve filtering Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 9/9] mk: update make targets for classified testcases Reshma Pattan
2018-07-17 14:33 ` Burakov, Anatoly
2018-07-17 15:23 ` Pattan, Reshma
2018-07-17 14:40 ` Burakov, Anatoly
2018-07-17 15:18 ` Pattan, Reshma
[not found] <cover.1528404133.git.anatoly.burakov@intel.com>
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 2/9] autotest: fix invalid code on reports Reshma Pattan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531833331-18148-3-git-send-email-reshma.pattan@intel.com \
--to=reshma.pattan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).