From: Luca Boccassi <bluca@debian.org>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
ankur.dwivedi@cavium.com, declan.doherty@intel.com
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms
Date: Mon, 23 Jul 2018 18:09:01 +0100 [thread overview]
Message-ID: <1532365741.7624.10.camel@debian.org> (raw)
In-Reply-To: <20180716062551.29742-1-pablo.de.lara.guarch@intel.com>
On Mon, 2018-07-16 at 07:25 +0100, Pablo de Lara wrote:
> When performing authentication verification (both for AEAD
> algorithms,
> such as AES-GCM, or for authentication algorithms, such as SHA1-
> HMAC),
> the digest address is calculated based on the packet size and the
> algorithm used (substracting digest size and IP header to the packet
> size).
>
> However, for AEAD algorithms, this was not calculated correctly,
> since the digest size was not being substracted.
>
> Bugzilla ID: 44
> Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters")
> Cc: stable@dpdk.org
>
> Reported-by: Ankur Dwivedi <ankur.dwivedi@cavium.com>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> examples/l2fwd-crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-
> crypto/main.c
> index 9d6bb7857..9ac06a697 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -408,7 +408,7 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,
> /* Zero pad data to be crypto'd so it is block aligned */
> data_len = rte_pktmbuf_data_len(m) - ipdata_offset;
>
> - if (cparams->do_hash && cparams->hash_verify)
> + if ((cparams->do_hash || cparams->do_aead) && cparams-
> >hash_verify)
> data_len -= cparams->digest_length;
>
> if (cparams->do_cipher) {
Hi Pablo,
For which stable release branch is this patch intended? Has it (or an
equivalent) been merged into mainline?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-07-23 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 6:25 Pablo de Lara
2018-07-23 17:09 ` Luca Boccassi [this message]
2018-07-23 17:56 ` De Lara Guarch, Pablo
2018-07-16 8:26 Pablo de Lara
2018-07-17 5:42 ` Dwivedi, Ankur
2018-07-17 8:08 ` De Lara Guarch, Pablo
2018-07-17 8:14 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532365741.7624.10.camel@debian.org \
--to=bluca@debian.org \
--cc=ankur.dwivedi@cavium.com \
--cc=declan.doherty@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).