From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build
Date: Fri, 31 Aug 2018 11:35:27 +0100 [thread overview]
Message-ID: <1535711727.11823.24.camel@debian.org> (raw)
In-Reply-To: <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com>
On Fri, 2018-08-31 at 11:17 +0100, Bruce Richardson wrote:
> On Fri, Aug 31, 2018 at 10:20:27AM +0100, Luca Boccassi wrote:
> > This PMD is built with -Wno-format, which means GCC errors out if
> > -Wformat-security is used.
> >
> > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share
> > code")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > drivers/raw/ifpga_rawdev/base/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/raw/ifpga_rawdev/base/meson.build
> > b/drivers/raw/ifpga_rawdev/base/meson.build
> > index cb6553521d..aadfc19084 100644
> > --- a/drivers/raw/ifpga_rawdev/base/meson.build
> > +++ b/drivers/raw/ifpga_rawdev/base/meson.build
> > @@ -19,7 +19,7 @@ sources = [
> >
> > error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
> > '-Wno-format', '-Wno-unused-but-set-variable',
> > - '-Wno-strict-aliasing'
> > + '-Wno-strict-aliasing', '-Wno-error=format-
> > security'
>
> For readability, should format-security be placed right beside the
> Wno-format, since both go together? Makes the diff a little bigger,
> but the
> result would be better, I feel.
>
> /Bruce
Sure, will change that.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-08-31 10:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 9:20 [dpdk-dev] [PATCH 1/4] build: include missing hypervisor files in Meson build Luca Boccassi
2018-08-31 9:20 ` [dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-08-31 10:17 ` Bruce Richardson
2018-08-31 10:35 ` Luca Boccassi [this message]
2018-08-31 9:20 ` [dpdk-dev] [PATCH 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-08-31 9:20 ` [dpdk-dev] [PATCH 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-08-31 10:15 ` Bruce Richardson
2018-08-31 10:19 ` Luca Boccassi
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 1/4] build: include missing hypervisor files in Meson build Luca Boccassi
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-08-31 11:01 ` Bruce Richardson
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-08-31 11:01 ` Bruce Richardson
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-08-31 11:06 ` Bruce Richardson
2018-08-31 11:00 ` [dpdk-dev] [PATCH v2 1/4] build: include missing hypervisor files in Meson build Bruce Richardson
2018-09-16 9:00 ` Thomas Monjalon
2018-09-17 8:20 ` Bruce Richardson
2018-09-17 9:01 ` Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 " Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-09-17 10:20 ` [dpdk-dev] [PATCH v3 1/4] build: include missing hypervisor files in Meson build Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535711727.11823.24.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).