From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, chaozhu@linux.vnet.ibm.com,
christian.ehrhardt@canonical.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] build: add PPC64 Meson build
Date: Mon, 10 Sep 2018 12:33:33 +0100 [thread overview]
Message-ID: <1536579213.10952.0.camel@debian.org> (raw)
In-Reply-To: <20180910105029.GB24376@bricha3-MOBL.ger.corp.intel.com>
On Mon, 2018-09-10 at 11:50 +0100, Bruce Richardson wrote:
> On Fri, Sep 07, 2018 at 07:35:02PM +0100, Luca Boccassi wrote:
> > This has been only build-tested for now, on a native ppc64el
> > POWER8E
> > machine running Debian sid.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > The build box cannot be used to run DPDK as it doesn't have
> > supported
> > NICs and root access. Would be great if someone could run-test it,
> > but
> > at this point I think build support is enough to get started.
> >
> > config/meson.build | 8 ++++++++
> > config/ppc_64/meson.build | 15
> > +++++++++++++++
> > lib/librte_eal/common/arch/ppc_64/meson.build | 5 +++++
> > .../common/include/arch/ppc_64/meson.build | 16
> > ++++++++++++++++
> > 4 files changed, 44 insertions(+)
> > create mode 100644 config/ppc_64/meson.build
> > create mode 100644 lib/librte_eal/common/arch/ppc_64/meson.build
> > create mode 100644
> > lib/librte_eal/common/include/arch/ppc_64/meson.build
> >
> > diff --git a/config/meson.build b/config/meson.build
> > index 4d755323f4..8e87b344c2 100644
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -9,7 +9,13 @@ else
> > endif
> > dpdk_conf.set('RTE_MACHINE', machine)
> > machine_args = []
> > +# ppc64 does not support -march=native
> > +if host_machine.cpu_family().startswith('ppc') and machine ==
> > 'native'
> > +machine_args += '-mcpu=' + machine
> > +machine_args += '-mtune=' + machine
> > +else
> > machine_args += '-march=' + machine
> > +endif
>
> Indentation?
Was left in the keyboard
> >
> > toolchain = cc.get_id()
> > dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain)
> > @@ -84,6 +90,8 @@ if host_machine.cpu_family().startswith('x86')
> > arch_subdir = 'x86'
> > elif host_machine.cpu_family().startswith('arm') or
> > host_machine.cpu_family().startswith('aarch')
> > arch_subdir = 'arm'
> > +elif host_machine.cpu_family().startswith('ppc')
> > + arch_subdir = 'ppc_64'
> > endif
> > subdir(arch_subdir)
> > dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS',
> > ','.join(compile_time_cpuflags))
> > diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build
> > new file mode 100644
> > index 0000000000..d6faa7d64f
> > --- /dev/null
> > +++ b/config/ppc_64/meson.build
> > @@ -0,0 +1,15 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
> > +
> > +# for checking defines we need to use the correct compiler flags
> > +march_opt = '-march=@0@'.format(machine)
>
> This contradicts the statement above in config/meson.build where you
> state
> that ppc64 doesn't support "-march=native"?
Yeah I copy-pasted the arm file to get started, but it doesn't seem to
me march_opt is used anywhere else other than in the x86 specific file,
so I've dropped that line in v2
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-09-10 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 18:35 Luca Boccassi
2018-09-10 7:26 ` Chao Zhu
2018-09-10 10:50 ` Bruce Richardson
2018-09-10 11:33 ` Luca Boccassi [this message]
2018-09-10 11:32 ` [dpdk-dev] [PATCH v2] " Luca Boccassi
2018-09-10 13:28 ` Bruce Richardson
2018-09-17 10:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536579213.10952.0.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).