From: Luca Boccassi <bluca@debian.org>
To: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>,
dev@dpdk.org
Cc: alejandro.lucero@netronome.com, allain.legacy@windriver.com,
jasvinder.singh@intel.com, keith.wiles@intel.com,
matan@mellanox.com, bruce.richardson@intel.com,
reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD
Date: Thu, 27 Sep 2018 14:42:32 +0100 [thread overview]
Message-ID: <1538055752.8363.32.camel@debian.org> (raw)
In-Reply-To: <1538054652-20820-7-git-send-email-agalyax.babu.radhakrishnan@intel.com>
On Thu, 2018-09-27 at 14:24 +0100, Agalya Babu RadhaKrishnan wrote:
> Disabled vdev_netvsc build in FreeBSD because it is not supported
> Added changes to enable vdev_netvsc build if it is Linux OS and
> disable in FreeBSD.
>
> Fixes: 6e8a721044 ("vfio: export functions even when disabled")
>
> Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@
> intel.com>
> ---
Hi,
I don't think these "Fixes" lines in this set are correct - for
example, the vdev_netvsc pmd only got the Meson file recently, but the
mentioned commit was back in 18.05. This would cause this individual
patch to be picked for the 18.08.1 stable release, even though it
shouldn't as the Meson file would be new in 18.11. Same might be true
for the other patches.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-09-27 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 13:24 [dpdk-dev] [PATCH 0/6] fix for meson builds in freebsd Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 1/6] build: fix for FREEBSD build via meson Agalya Babu RadhaKrishnan
2018-09-27 14:49 ` Bruce Richardson
2018-09-27 14:49 ` Bruce Richardson
2018-09-27 13:24 ` [dpdk-dev] [PATCH 2/6] net/nfp: disable nfp build in FREEBSD Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 3/6] net/avp: disable avp " Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 4/6] net/softnic: disable softnic " Agalya Babu RadhaKrishnan
2018-09-27 13:49 ` Singh, Jasvinder
2018-09-27 13:24 ` [dpdk-dev] [PATCH 5/6] net/tap: disable tap " Agalya Babu RadhaKrishnan
2018-09-27 13:45 ` Wiles, Keith
2018-09-27 13:24 ` [dpdk-dev] [PATCH 6/6] net/vdev_netvsc: disable vdev netvsc " Agalya Babu RadhaKrishnan
2018-09-27 13:42 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538055752.8363.32.camel@debian.org \
--to=bluca@debian.org \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=allain.legacy@windriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=keith.wiles@intel.com \
--cc=matan@mellanox.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).