From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] build: add meson.build for kni kernel module
Date: Fri, 12 Oct 2018 16:13:46 +0100 [thread overview]
Message-ID: <1539357226.8721.43.camel@debian.org> (raw)
In-Reply-To: <20181012140930.GA21308@bricha3-MOBL.ger.corp.intel.com>
On Fri, 2018-10-12 at 15:09 +0100, Bruce Richardson wrote:
> On Thu, Oct 11, 2018 at 08:46:29PM +0100, Luca Boccassi wrote:
> > A Kbuild is also included to allow users to use DKMS natively
> > without
> > additional code.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > build-tested on debian sid am64
> >
> > kernel/linux/kni/Kbuild | 8 ++++++
> > kernel/linux/kni/meson.build | 51
> > ++++++++++++++++++++++++++++++++++++
> > kernel/linux/meson.build | 2 +-
> > 3 files changed, 60 insertions(+), 1 deletion(-)
> > create mode 100644 kernel/linux/kni/Kbuild
> > create mode 100644 kernel/linux/kni/meson.build
> >
>
> I get a couple of errors building this on Fedora 28. First problem is
> that
> I get a compilation error for a missing rte_fifo.h. The fix for that
> error
> is to ensure the current dir is on the include list:
>
> ' -I' + meson.build_root() +
> + ' -I' + meson.current_source_dir() +
> ' -I' + meson.current_source_dir() + '/ethtool/ixgbe'
> +
>
> Then I hit a second error, where the compile fails because the output
> directory for the ethdev files does not exist.
>
> Fatal error: can't create /home/bruce/dpdk-clean/build-gcc-
> static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o: No such file
> or directory
> make[1]: *** [scripts/Makefile.build:318: /home/bruce/dpdk-
> clean/build-gcc-
> static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o] Error 2
>
> I haven't fixed this, but I think the easiest fix is probably to
> split the
> file lists so that each file is listed in a meson.build in its own
> subdirectory. Then using subdir to build up the file list rather than
> having it all at one gom should cause meson to create the
> subdirectory
> structure in the build directory.
> There may be other, better solutions, though.
>
> /Bruce
Hi,
Interesting, I guess it's down to differences between the kernel
makefiles in Debian and Fedora? Although the include one is strange.
I've sent a v2 with your suggestions, please give it a run when you've
got a sec.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-10-12 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:46 Luca Boccassi
2018-10-12 14:09 ` Bruce Richardson
2018-10-12 15:13 ` Luca Boccassi [this message]
2018-10-12 15:12 ` [dpdk-dev] [PATCH v2] " Luca Boccassi
2018-10-12 16:29 ` Bruce Richardson
2018-10-12 17:06 ` Luca Boccassi
[not found] ` <CGME20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114@eucas1p1.samsung.com>
2018-10-29 14:09 ` Ilya Maximets
2018-10-29 15:33 ` Luca Boccassi
2018-10-30 10:38 ` Bruce Richardson
2018-10-12 17:05 ` [dpdk-dev] [PATCH v3] " Luca Boccassi
2018-10-31 10:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539357226.8721.43.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).