From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module
Date: Fri, 12 Oct 2018 18:06:41 +0100 [thread overview]
Message-ID: <1539364001.8721.45.camel@debian.org> (raw)
In-Reply-To: <20181012162938.GA11676@bricha3-MOBL.ger.corp.intel.com>
On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote:
> On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote:
> > A Kbuild is also included to allow users to use DKMS natively
> > without
> > additional code.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > v2: add local directory to -I and build sources list recursively to
> > fix build on Fedora
> >
>
> Yep, now seems to build for me on Fedora. One minor suggestion is to
> look
> to use the "console" keyword on the custom_target if possible. It
> should
> help prevent noticable stalls as make runs in the background.
> [Unfortunately, it's meson 0.48 onward only, so if conditionals are
> needed,
> just ignore this suggestion]
Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there are
no complaints or errors, it's simply ignored in the older versions.
> Also, do we want to use "make -j" for this, given the number of
> files?
> [Maybe -j4 just?]
Yeah makes sense, added j4.
Sent v3 with both changes and the ack, thanks.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-10-12 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:46 [dpdk-dev] [PATCH] " Luca Boccassi
2018-10-12 14:09 ` Bruce Richardson
2018-10-12 15:13 ` Luca Boccassi
2018-10-12 15:12 ` [dpdk-dev] [PATCH v2] " Luca Boccassi
2018-10-12 16:29 ` Bruce Richardson
2018-10-12 17:06 ` Luca Boccassi [this message]
[not found] ` <CGME20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114@eucas1p1.samsung.com>
2018-10-29 14:09 ` Ilya Maximets
2018-10-29 15:33 ` Luca Boccassi
2018-10-30 10:38 ` Bruce Richardson
2018-10-12 17:05 ` [dpdk-dev] [PATCH v3] " Luca Boccassi
2018-10-31 10:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539364001.8721.45.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).