From: Luca Boccassi <bluca@debian.org>
To: Timothy Redaelli <tredaelli@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: don't install meson.build in usertools
Date: Wed, 28 Nov 2018 10:13:24 +0000 [thread overview]
Message-ID: <1543400004.5087.13.camel@debian.org> (raw)
In-Reply-To: <f4aeee269d9d83e8e65ea6acd62933da6b31102d.1543347246.git.tredaelli@redhat.com>
On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote:
> In commit 7dd34c71de2a ("usertools: install with meson") meson.build
> was
> added in usertools directory and so it's copied to
> $(datadir)/usertools
> with "make install".
>
> This patch avoids to copy meson.build when installing usertools with
> "make install".
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> mk/rte.sdkinstall.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 8296e6dbd..2d34b4e5a 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -99,8 +99,9 @@ install-runtime:
> --exclude 'app/cmdline*' --exclude app/test \
> --exclude app/testacl --exclude app/testpipeline app
> | \
> tar -xf - -C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)
> - $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))
> - $(Q)cp $(CP_FLAGS) $(RTE_SDK)/usertools $(DESTDIR)$(datadir)
> + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)/usertools)
> + $(Q)tar -cf - -C $(RTE_SDK) --exclude meson.build
> usertools | \
> + tar -xf - -C $(DESTDIR)$(datadir)/usertools
> $(TAR_X_FLAGS)
> $(Q)$(call rte_mkdir, $(DESTDIR)$(sbindir))
> $(Q)$(call
> rte_symlink, $(DESTDIR)$(datadir)/usertools/dpdk-devbind.py, \
> $(DESTDIR)$(sbindir)/dpdk-
> devbind)
Acked-by: Luca Boccassi <bluca@debian.org>
Should probably add:
Fixes: 7dd34c71de2a ("usertools: install with meson")
Cc: stable@dpdk.org
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-11-28 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:35 Timothy Redaelli
2018-11-28 10:13 ` Luca Boccassi [this message]
2018-12-19 0:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543400004.5087.13.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).