From: Mohammed Gamal <mgamal@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation
Date: Mon, 03 Dec 2018 07:02:55 +0100 [thread overview]
Message-ID: <1543816975.5400.35.camel@redhat.com> (raw)
In-Reply-To: <20181130202457.10888-1-stephen@networkplumber.org>
On Fri, 2018-11-30 at 12:24 -0800, Stephen Hemminger wrote:
> When using multiple queues, there was a race with the kernel
> in setting up the second channel. This is do due to a kernel change
> whiche does not allow accessing sysfs files for Hyper-V
> channels that are not opened.
>
> The fix is simple, just move the logic to detect not ready
> sub channels earlier in the existing loop.
>
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Reported-by:Mohammed Gamal <mgamal@redhat.com>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> drivers/bus/vmbus/linux/vmbus_uio.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c
> b/drivers/bus/vmbus/linux/vmbus_uio.c
> index 12e97e3a420a..38df4d724ed5 100644
> --- a/drivers/bus/vmbus/linux/vmbus_uio.c
> +++ b/drivers/bus/vmbus/linux/vmbus_uio.c
> @@ -357,6 +357,12 @@ int vmbus_uio_get_subchan(struct vmbus_channel
> *primary,
> continue;
> }
>
> + if (!vmbus_isnew_subchannel(primary, relid))
> + continue; /* Already know about you
> */
> +
> + if (!vmbus_uio_ring_present(dev, relid))
> + continue; /* Ring may not be ready
> yet */
> +
> snprintf(subchan_path, sizeof(subchan_path),
> "%s/%lu",
> chan_path, relid);
> err = vmbus_uio_sysfs_read(subchan_path,
> "subchannel_id",
> @@ -370,12 +376,6 @@ int vmbus_uio_get_subchan(struct vmbus_channel
> *primary,
> if (subid == 0)
> continue; /* skip primary channel */
>
> - if (!vmbus_isnew_subchannel(primary, relid))
> - continue;
> -
> - if (!vmbus_uio_ring_present(dev, relid))
> - continue; /* Ring may not be ready
> yet */
> -
> err = vmbus_uio_sysfs_read(subchan_path,
> "monitor_id",
> &monid, UINT8_MAX);
> if (err) {
With this patch I am now getting the following error:
[...]
Configuring Port 0 (socket 0)
hn_dev_configure(): >>
hn_rndis_link_status(): link status 0x40020006
hn_subchan_configure(): open 1 subchannels
hn_subchan_configure(): open subchannel failed: -2
hn_dev_configure(): subchannel configuration failed
Port0 dev_configure = -2
hn_dev_rx_queue_release(): >>
hn_dev_rx_queue_release(): >>
hn_dev_tx_queue_release(): >>
hn_dev_tx_queue_release(): >>
Fail to configure port 0
EAL: Error - exiting with code: 1
Cause: Start ports failed
Apparently, no subchannels were ready. Anything I may have missed or
misconfigured?
Regards,
Mohammed
next prev parent reply other threads:[~2018-12-03 6:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 11:04 [dpdk-dev] Problems running netvsc multiq Mohammed Gamal
2018-11-30 18:27 ` Stephen Hemminger
2018-11-30 19:06 ` Mohammed Gamal
2018-12-04 16:48 ` Stephen Hemminger
2018-12-04 16:56 ` Mohammed Gamal
2018-12-05 22:12 ` Stephen Hemminger
2018-12-05 22:32 ` Stephen Hemminger
2018-12-07 11:15 ` Mohammed Gamal
2018-12-07 17:31 ` Stephen Hemminger
2018-12-07 19:18 ` Stephen Hemminger
2018-12-08 8:10 ` Mohammed Gamal
2018-11-30 20:24 ` [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation Stephen Hemminger
2018-12-03 6:02 ` Mohammed Gamal [this message]
2018-12-03 16:48 ` Stephen Hemminger
2018-12-04 11:59 ` Mohammed Gamal
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 1/4] " Stephen Hemminger
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 2/4] net/netvsc: enable SR-IOV Stephen Hemminger
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 3/4] net/netvsc: disable multi-queue on older servers Stephen Hemminger
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 4/4] bus/vmbus: debug subchannel setup Stephen Hemminger
2018-12-19 2:02 ` [dpdk-dev] [PATCH v2 1/4] bus/vmbus: fix race in sub channel creation Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543816975.5400.35.camel@redhat.com \
--to=mgamal@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).