From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "Hunt, David" <david.hunt@intel.com>,
Liang Ma <liang.j.ma@intel.com>,
dev@dpdk.org, qian.q.xu@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility
Date: Thu, 20 Dec 2018 11:42:20 +0100 [thread overview]
Message-ID: <1545302540.9718.20.camel@debian.org> (raw)
In-Reply-To: <9037763.qK0Rf51nFT@xps>
On Thu, 2018-12-20 at 11:10 +0100, Thomas Monjalon wrote:
> 20/12/2018 10:33, Burakov, Anatoly:
> > On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote:
> > > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote:
> > > > 19/12/2018 10:09, Hunt, David:
> > > > > On 19/12/2018 3:18 AM, Thomas Monjalon wrote:
> > > > > > 14/12/2018 14:11, Liang Ma:
> > > > > > > Previously, in order to use the power library, it was
> > > > > > > necessary
> > > > > > > for the user to disable the intel_pstate driver by adding
> > > > > > > “intel_pstate=disable” to the kernel command line for the
> > > > > > > system,
> > > > > > > which causes the acpi_cpufreq driver to be loaded in its
> > > > > > > place.
> > > > > > >
> > > > > > > This patch adds the ability for the power library use the
> > > > > > > intel-pstate
> > > > > > > driver.
> > > > > > >
> > > > > > > It adds a new suite of functions behind the current power
> > > > > > > library API,
> > > > > > > and will seamlessly set up the user facing API function
> > > > > > > pointers to
> > > > > > > the relevant functions depending on whether the system is
> > > > > > > running with
> > > > > > > acpi_cpufreq kernel driver, intel_pstate kernel driver or
> > > > > > > in a guest,
> > > > > > > using kvm. The library API and ABI is unchanged.
> > > > > > >
> > > > > > > Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> > > > > > >
> > > > > > > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > > > > > > ---
> > > > > >
> > > > > > Please write a changelog when sending a new version.
> > > > > >
> > > > > > Dave, any comment on this patch?
> > > > >
> > > > >
> > > > > Looks good to me.
> > > > >
> > > > > Acked-by: David Hunt <david.hunt@intel.com>
> > > > >
> > > > >
> > > > > > > --- /dev/null
> > > > > > > +++ b/lib/librte_power/power_pstate_cpufreq.c
> > > > > > > @@ -0,0 +1,770 @@
> > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > > > > > + * Copyright(c) 2018-2018 Intel Corporation
> > > > > >
> > > > > > Something wrong here :)
> > > > >
> > > > > Yes, should simply be "Copyright(c) 2018 Intel Corporation"
> > > >
> > > >
> > > > There is also a compilation error with meson:
> > > >
> > > > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error:
> > > > rte_timer.h: No such file or directory
> > >
> > > That's an EAL header, and this file was not modified or
> > > referenced in
> > > this commit. This sounds like a pre-existing problem (with meson
> > > build-system?), not related to the patchset.
> > >
> > > Is this library not built by default by our patch compilation CI?
> > >
> >
> > Disregard that, the patch has a bug in meson build file.
> >
> > Still, why doesn't our CI build meson?
>
> I think we should build a new CI for compilation testing.
> Luca proposed to use OBS.
> Luca, can we work on it?
https://build.opensuse.org/package/show/home:bluca:dpdk/dpdk
The Debian/Ubuntu builds use Meson, the Fedora/CentOS/RHEL/SUSE ones
use the makefiles.
More complexity (eg: building with both on all distros) can be added
with a bit of work, if required and if it's worth it.
A postreceive curl call can be added to trigger it on every push to
master. Emails on failure can be sent with the logs.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-12-20 10:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 11:33 [dpdk-dev] [PATCH] " Liang Ma
2018-12-10 16:08 ` Burakov, Anatoly
2018-12-13 10:58 ` Liang, Ma
2018-12-13 11:16 ` Burakov, Anatoly
2018-12-13 13:46 ` Liang, Ma
2018-12-13 13:53 ` Burakov, Anatoly
2018-12-14 11:13 ` [dpdk-dev] [PATCH v2] " Liang Ma
2018-12-14 12:20 ` Burakov, Anatoly
2018-12-14 13:11 ` [dpdk-dev] [PATCH v3] " Liang Ma
2018-12-19 3:18 ` Thomas Monjalon
2018-12-19 9:09 ` Hunt, David
2018-12-19 20:31 ` Thomas Monjalon
2018-12-20 9:25 ` Burakov, Anatoly
2018-12-20 9:33 ` Burakov, Anatoly
2018-12-20 10:10 ` Thomas Monjalon
2018-12-20 10:42 ` Luca Boccassi [this message]
2018-12-20 10:44 ` Thomas Monjalon
2018-12-20 10:54 ` Liang, Ma
2018-12-20 14:52 ` Hunt, David
2018-12-21 0:30 ` Thomas Monjalon
2018-12-21 0:33 ` Thomas Monjalon
2018-12-20 14:43 ` [dpdk-dev] [PATCH v4] " Liang Ma
2018-12-21 0:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545302540.9718.20.camel@debian.org \
--to=bluca@debian.org \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=liang.j.ma@intel.com \
--cc=qian.q.xu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).