From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, dev@dpdk.org
Cc: orika@nvidia.com, matan@nvidia.com, thomas@monjalon.net,
adwivedi@marvell.com
Subject: Re: [PATCH] ethdev: fix asynchronous destroy and push tracepoints
Date: Fri, 19 May 2023 10:00:20 +0100 [thread overview]
Message-ID: <15464a44-84c6-1b84-9c80-a6c62c43b85a@amd.com> (raw)
In-Reply-To: <20230518215928.2366851-1-akozyrev@nvidia.com>
On 5/18/2023 10:59 PM, Alexander Kozyrev wrote:
>
> The rte_flow_async_destroy() and rte_flow_push() API is
> intended to be as fast as possible and tracepoints for
> these functions must be marked as fast-path tracepoints.
>
> Fixes: 6679cf21d608 ("ethdev: add trace points")
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
<...>
> +RTE_TRACE_POINT_FP(
> + rte_flow_trace_async_destroy,
> + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
> + const struct rte_flow_op_attr *op_attr,
> + const struct rte_flow *flow, const void *user_data, int ret),
> + rte_trace_point_emit_u16(port_id);
> + rte_trace_point_emit_u32(queue_id);
> + rte_trace_point_emit_ptr(op_attr);
> + rte_trace_point_emit_ptr(flow);
> + rte_trace_point_emit_ptr(user_data);
> + rte_trace_point_emit_int(ret);
> +)
> +
> RTE_TRACE_POINT_FP(
> rte_flow_trace_async_update,
> RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
> @@ -2374,6 +2366,14 @@ RTE_TRACE_POINT_FP(
> rte_trace_point_emit_int(ret);
> )
>
> +RTE_TRACE_POINT_FP(
> + rte_flow_trace_push,
> + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret),
> + rte_trace_point_emit_u16(port_id);
> + rte_trace_point_emit_u32(queue_id);
> + rte_trace_point_emit_int(ret);
> +)
> +
Patch doesn't apply cleanly because it can't find
'rte_flow_trace_async_update', is there a dependency?
next prev parent reply other threads:[~2023-05-19 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 21:59 Alexander Kozyrev
2023-05-19 5:21 ` [EXT] " Ankur Dwivedi
2023-05-21 19:09 ` Ori Kam
2023-05-19 9:00 ` Ferruh Yigit [this message]
2023-05-23 17:37 ` Alexander Kozyrev
2023-05-23 17:39 ` [PATCH v2] " Alexander Kozyrev
2023-05-24 9:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15464a44-84c6-1b84-9c80-a6c62c43b85a@amd.com \
--to=ferruh.yigit@amd.com \
--cc=adwivedi@marvell.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).