From: Hari kumar Vemula <hari.kumarx.vemula@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, reshma.pattan@intel.com, ferruh.yigit@intel.com,
david.marchand@redhat.com, jananeex.m.parthasarathy@intel.com,
Hari kumar Vemula <hari.kumarx.vemula@intel.com>
Subject: [dpdk-stable] [PATCH v2] eal: fix core number validation
Date: Thu, 3 Jan 2019 12:28:07 +0000 [thread overview]
Message-ID: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com> (raw)
In-Reply-To: <yes>
When incorrect core value or range provided,
as part of -l command line option, a crash occurs.
Added valid range checks to fix the crash.
Fixes: d888cb8b9613 ("eal: add core list input format")
Cc: stable@dpdk.org
--
v2: Replace strtoul with strtol
Modified log message
--
Signed-off-by: Hari kumar Vemula <hari.kumarx.vemula@intel.com>
---
lib/librte_eal/common/eal_common_options.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 6e3a83b98..b24668c23 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -592,7 +592,7 @@ eal_parse_corelist(const char *corelist)
if (*corelist == '\0')
return -1;
errno = 0;
- idx = strtoul(corelist, &end, 10);
+ idx = strtol(corelist, &end, 10);
if (errno || end == NULL)
return -1;
while (isblank(*end))
@@ -603,6 +603,11 @@ eal_parse_corelist(const char *corelist)
max = idx;
if (min == RTE_MAX_LCORE)
min = idx;
+ if ((unsigned int)idx >= cfg->lcore_count ||
+ (unsigned int)min >= cfg->lcore_count) {
+ return -1;
+ }
+
for (idx = min; idx <= max; idx++) {
if (cfg->lcore_role[idx] != ROLE_RTE) {
cfg->lcore_role[idx] = ROLE_RTE;
@@ -1103,6 +1108,7 @@ eal_parse_common_option(int opt, const char *optarg,
{
static int b_used;
static int w_used;
+ struct rte_config *cfg = rte_eal_get_configuration();
switch (opt) {
/* blacklist */
@@ -1145,7 +1151,9 @@ eal_parse_common_option(int opt, const char *optarg,
/* corelist */
case 'l':
if (eal_parse_corelist(optarg) < 0) {
- RTE_LOG(ERR, EAL, "invalid core list\n");
+ RTE_LOG(ERR, EAL,
+ "Invalid core number given core range should be(0, %u)\n",
+ cfg->lcore_count-1);
return -1;
}
--
2.17.2
next parent reply other threads:[~2019-01-03 12:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yes>
2019-01-03 12:28 ` Hari kumar Vemula [this message]
2019-01-03 13:03 ` David Marchand
2019-01-07 7:05 ` Hari Kumar Vemula
2019-01-07 10:25 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-10 10:11 ` David Marchand
2019-01-11 14:15 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-11 15:06 ` David Marchand
2019-01-14 10:08 ` [dpdk-stable] [PATCH v5] " Hari Kumar Vemula
2019-01-14 10:28 ` Hari Kumar Vemula
2019-01-14 14:39 ` David Marchand
2019-01-17 10:11 ` [dpdk-stable] [PATCH v6] " Hari Kumar Vemula
2019-01-17 12:13 ` Hari Kumar Vemula
2019-01-17 12:19 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-01-17 12:32 ` David Marchand
2019-01-17 16:29 ` [dpdk-stable] " Thomas Monjalon
2019-01-17 16:31 ` Thomas Monjalon
2019-01-04 13:10 ` [dpdk-stable] [PATCH v2] " Hari kumar Vemula
2019-01-07 13:01 ` [dpdk-stable] [PATCH] net/bonding: fix create bonded device test failure Hari Kumar Vemula
2019-01-07 18:44 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2019-01-08 10:27 ` Ferruh Yigit
2019-01-15 17:37 ` [dpdk-stable] " Pattan, Reshma
2019-01-28 7:28 ` [dpdk-stable] [PATCH v2] " Hari Kumar Vemula
2019-01-31 23:40 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2019-02-05 13:39 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-02-07 13:34 ` Ferruh Yigit
2019-01-08 6:18 ` [dpdk-stable] [PATCH] " Hari Kumar Vemula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com \
--to=hari.kumarx.vemula@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).