patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
To: dev@dpdk.org
Cc: byron.marohn@intel.com, reshma.pattan@intel.com,
	pablo.de.lara.guarch@intel.com,
	jananeex.m.parthasarathy@intel.com,
	Hari Kumar Vemula <hari.kumarx.vemula@intel.com>,
	stable@dpdk.org
Subject: [dpdk-stable] [PATCH v5] lib/efd: fix to free tail queue entry after use
Date: Fri, 18 Jan 2019 07:40:42 +0000	[thread overview]
Message-ID: <1547797242-7553-1-git-send-email-hari.kumarx.vemula@intel.com> (raw)
In-Reply-To: <1542109533-14283-1-git-send-email-hari.kumarx.vemula@intel.com>

In rte_efd_create() allocated memory for tail queue entry but
not freed.
Added freeing the tail queue entry.

Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: stable@dpdk.org

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.nagarahalli@arm.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
v5: Removed NULL initialization
v4: RTE_TAILQ_CAST moved after for loop
v3: Replaced TAILQ_FOREACH_SAFE with TAILQ_FOREACH
v2: Updated commit message.
---
 lib/librte_efd/rte_efd.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
index e6e5cfda2..1a97ece05 100644
--- a/lib/librte_efd/rte_efd.c
+++ b/lib/librte_efd/rte_efd.c
@@ -740,6 +740,8 @@ void
 rte_efd_free(struct rte_efd_table *table)
 {
 	uint8_t socket_id;
+	struct rte_efd_list *efd_list;
+	struct rte_tailq_entry *te, *temp;
 
 	if (table == NULL)
 		return;
@@ -747,6 +749,18 @@ rte_efd_free(struct rte_efd_table *table)
 	for (socket_id = 0; socket_id < RTE_MAX_NUMA_NODES; socket_id++)
 		rte_free(table->chunks[socket_id]);
 
+	efd_list = RTE_TAILQ_CAST(rte_efd_tailq.head, rte_efd_list);
+	rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+
+	TAILQ_FOREACH_SAFE(te, efd_list, next, temp) {
+		if (te->data == (void *) table) {
+			TAILQ_REMOVE(efd_list, te, next);
+			rte_free(te);
+			break;
+		}
+	}
+
+	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
 	rte_ring_free(table->free_slots);
 	rte_free(table->offline_chunks);
 	rte_free(table->keys);
-- 
2.17.2

  parent reply	other threads:[~2019-01-18  7:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 11:45 [dpdk-stable] [PATCH] lib: fix to free trail " Hari Kumar Vemula
2018-11-13 16:43 ` Pattan, Reshma
2018-11-14 11:17 ` [dpdk-stable] [PATCH v2] lib/efd: fix to free tail " Hari Kumar Vemula
2018-11-18 14:57   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-11-23 13:30   ` Maxime Coquelin
2018-11-23 14:39     ` Maxime Coquelin
2019-01-11 11:49 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-14 22:30   ` Thomas Monjalon
2019-01-14 22:39     ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
2019-01-17 13:36 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-17 16:41   ` De Lara Guarch, Pablo
2019-01-18  7:40 ` Hari Kumar Vemula [this message]
2019-01-18 18:21   ` [dpdk-stable] [dpdk-dev] [PATCH v5] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547797242-7553-1-git-send-email-hari.kumarx.vemula@intel.com \
    --to=hari.kumarx.vemula@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).