From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support
Date: Fri, 14 Oct 2016 17:08:08 +0200 [thread overview]
Message-ID: <1551628.WMOZ8qHgAT@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com>
2016-10-12 20:44, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > This patchset was probably not tested as it does not compile.
> > And it could be useless if a TAP PMD is integrated.
> > I suggest to wait 17.02 cycle and see.
>
> This patch was tested by me and Jasvinder as well and it works brilliantly.
>
> We did not enable stats when testing, will sort out the missing semicolon issue in the stats macros and resend v3 asap. This is a trivial issue, no need to wait for 17.02.
So the stats were not tested.
> This is not conflicting with TAP PMD, and as said the scope of this supersedes the TAP PMD.
The v3 has been applied and it breaks FreeBSD compilation now.
I felt it was not ready but you won with the words "it works brilliantly" ;)
(sorry I have not resisted to make the joke)
next prev parent reply other threads:[~2016-10-14 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 21:21 [dpdk-dev] [PATCH " Jasvinder Singh
2016-09-04 14:38 ` [dpdk-dev] [PATCH v2 " Jasvinder Singh
2016-09-04 14:38 ` [dpdk-dev] [PATCH v2 2/3] examples/ip_pipeline: integrate TAP port Jasvinder Singh
2016-09-04 14:38 ` [dpdk-dev] [PATCH v2 3/3] examples/ip_pipeline: add sample config file with TAP port usage Jasvinder Singh
[not found] ` <20160905101218.GA18384@bricha3-MOBL3>
2016-09-09 21:19 ` [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support Dumitrescu, Cristian
2016-10-12 20:33 ` Thomas Monjalon
2016-10-12 20:44 ` Dumitrescu, Cristian
2016-10-14 15:08 ` Thomas Monjalon [this message]
2016-10-13 9:17 ` [dpdk-dev] [PATCH v3 " Jasvinder Singh
2016-10-13 9:17 ` [dpdk-dev] [PATCH v3 2/3] examples/ip_pipeline: integrate TAP port Jasvinder Singh
2016-10-13 9:17 ` [dpdk-dev] [PATCH v3 3/3] examples/ip_pipeline: add sample config file with TAP port usage Jasvinder Singh
2016-10-13 12:38 ` [dpdk-dev] [PATCH v3 1/3] lib/librte_port: enable file descriptor port support Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551628.WMOZ8qHgAT@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).