From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map
Date: Mon, 02 Oct 2017 16:55:49 +0200 [thread overview]
Message-ID: <1556159.HUIlaTtd6f@xps> (raw)
In-Reply-To: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
Hi,
I have some comments about the API scope and some formatting.
Suggested title:
power: add turbo functions to map file
02/10/2017 14:20, David Hunt:
> allows vm_power_manager example to be built against shared libraries
Fixes: 94608a0f7f45 ("power: add per-core turbo boost API")
> Signed-off-by: David Hunt <david.hunt@intel.com>
[...]
> +DPDK_17.11 {
> + global:
> +
> + rte_power_acpi_turbo_status;
Is it really the function you want to expose?
rte_power_turbo_status seems more generic.
More comments about what is part of the API:
If you do not want to expose ACPI and VM implementations,
it should not be part of the rte_* include files.
> + rte_power_freq_disable_turbo;
> + rte_power_freq_enable_turbo;
> +};
> +
This is a trailing new line.
next prev parent reply other threads:[~2017-10-02 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 12:20 David Hunt
2017-10-02 14:53 ` [dpdk-dev] [PATCH v2] power: add turbo functions to map file David Hunt
2017-10-03 7:22 ` [dpdk-dev] [PATCH v3] " David Hunt
2017-10-03 8:40 ` Thomas Monjalon
2017-10-02 14:55 ` Thomas Monjalon [this message]
2017-10-02 15:06 ` [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map Hunt, David
2017-10-02 15:39 ` Thomas Monjalon
2017-10-02 16:25 ` Hunt, David
2017-10-02 16:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556159.HUIlaTtd6f@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).