From: Thomas Monjalon <thomas@monjalon.net>
To: "Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
dev@dpdk.org, yuanhan.liu@linux.intel.com
Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable
Date: Thu, 27 Apr 2017 11:20:22 +0200 [thread overview]
Message-ID: <1558565.2fZJ5xpf6Y@xps> (raw)
In-Reply-To: <8F6C2BD409508844A0EFC19955BE09415126F7FE@SHSMSX103.ccr.corp.intel.com>
27/04/2017 11:18, Wang, Zhihong:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 27/04/2017 18:34, Zhihong Wang:
> > > Making AVX and AVX512 configurable is useful for performance and power
> > > testing.
> > >
> > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.
> > [...]
> > > +#
> > > +# Recognize/ignore the AVX/AVX512 CPU flags for performance/power
> > testing
> > > +#
> > > +CONFIG_RTE_ENABLE_AVX=y
> > > +CONFIG_RTE_ENABLE_AVX512=n
> >
> > It is disabling AVX512 in default configuration.
> > Please explain this behaviour change.
>
> Though AVX512 rte_memcpy has been in DPDK for quite a while it's still
> unproven in hardware with rich use cases. Mark it as experimental for
> now, user can enable it for their own testing.
>
> Will enable it with enough field tests and possible optimization.
>
> Should I add the explanation in commit log, or comments in the source,
> or both?
Yes please, add the explanation in the commit log and experimental comment
in the config.
next prev parent reply other threads:[~2017-04-27 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 16:34 Zhihong Wang
2017-04-27 9:08 ` Thomas Monjalon
2017-04-27 9:18 ` Wang, Zhihong
2017-04-27 9:20 ` Thomas Monjalon [this message]
2017-04-27 10:03 ` Wang, Zhihong
2017-04-27 23:00 ` [dpdk-dev] [PATCH v2] " Zhihong Wang
2017-04-28 2:08 ` Yang, Zhiyong
2017-04-30 21:19 ` Thomas Monjalon
2017-04-28 5:07 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558565.2fZJ5xpf6Y@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).