From: Thomas Monjalon <thomas@monjalon.net>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: stable@dpdk.org, "De Lara Guarch,
Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH v3] kni: fix build with gcc 8.1
Date: Wed, 27 Jun 2018 15:15:11 +0200 [thread overview]
Message-ID: <1562187.JQU0VIWQ63@xps> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8DC763@IRSMSX108.ger.corp.intel.com>
26/06/2018 15:43, De Lara Guarch, Pablo:
>
> > Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
> > enabled.
> >
> > build error:
> > In function ‘strncpy’,
> > inlined from ‘igb_get_drvinfo’ at
> > .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:
> > .../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output
> > may be truncated copying 31 bytes from a string of length 42
> > [-Werror=stringop-truncation]
> > return __builtin_strncpy(p, q, size);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixed by using strlcpy instead of strncpy.
> >
> > adapter->fw_version size kept same because of
> > c3698192940c ("kni: fix build with gcc 7.1")
> >
> > Also next line strncpy usage replaced with strlcpy while arround.
> >
> > Fixes: c3698192940c ("kni: fix build with gcc 7.1")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-06-27 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:08 [dpdk-stable] [PATCH] " Ferruh Yigit
2018-06-19 23:35 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2018-06-20 16:39 ` Ferruh Yigit
2018-06-20 17:04 ` Ferruh Yigit
2018-06-20 9:01 ` [dpdk-stable] " De Lara Guarch, Pablo
2018-06-20 16:40 ` Ferruh Yigit
2018-06-26 9:02 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2018-06-26 9:54 ` Thomas Monjalon
2018-06-26 11:38 ` [dpdk-stable] [PATCH v3] " Ferruh Yigit
2018-06-26 13:43 ` De Lara Guarch, Pablo
2018-06-27 13:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562187.JQU0VIWQ63@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).