DPDK patches and discussions
 help / color / mirror / Atom feed
From: Harman Kalra <hkalra@marvell.com>
To: "reshma.pattan@intel.com" <reshma.pattan@intel.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Harman Kalra <hkalra@marvell.com>
Subject: [dpdk-dev] [PATCH v4] app/pdump: enforcing pdump to use SW mempool
Date: Wed, 10 Jul 2019 09:22:25 +0000	[thread overview]
Message-ID: <1562750519-5998-1-git-send-email-hkalra@marvell.com> (raw)
In-Reply-To: <1562661870-24471-1-git-send-email-hkalra@marvell.com>

A secondary process cannot access HW mempool already
initiazed by primary, and neither it can setup its own
HW mempool due to its own restrictions.

Since dpdk-pdump creates mempool for managing its local
mbufs, SW mempool is capable enough to solve this purpose.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 app/pdump/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 80dc924cf..cd0986aee 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -604,11 +604,11 @@ create_mp_ring_vdev(void)
 		mbuf_pool = rte_mempool_lookup(mempool_name);
 		if (mbuf_pool == NULL) {
 			/* create mempool */
-			mbuf_pool = rte_pktmbuf_pool_create(mempool_name,
+			mbuf_pool = rte_pktmbuf_pool_create_by_ops(mempool_name,
 					pt->total_num_mbufs,
 					MBUF_POOL_CACHE_SIZE, 0,
 					pt->mbuf_data_size,
-					rte_socket_id());
+					rte_socket_id(), "ring_mp_mc");
 			if (mbuf_pool == NULL) {
 				cleanup_rings();
 				rte_exit(EXIT_FAILURE,
-- 
2.18.0


  reply	other threads:[~2019-07-10  9:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 15:27 [dpdk-dev] [PATCH] app/pdump: enforcing pdump to use sw mempool Harman Kalra
2019-03-15 15:27 ` Harman Kalra
2019-07-04 16:29 ` Thomas Monjalon
2019-07-05 13:48   ` Olivier Matz
2019-07-05 14:39     ` [dpdk-dev] [EXT] " Harman Kalra
2019-07-05 15:09       ` Thomas Monjalon
2019-07-05 15:40         ` [dpdk-dev] [PATCH v2] " Harman Kalra
2019-07-05 15:50           ` Olivier Matz
2019-07-09  8:44             ` [dpdk-dev] [PATCH v3] " Harman Kalra
2019-07-10  9:22               ` Harman Kalra [this message]
2019-07-10 22:21                 ` [dpdk-dev] [PATCH v4] app/pdump: enforcing pdump to use SW mempool Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562750519-5998-1-git-send-email-hkalra@marvell.com \
    --to=hkalra@marvell.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=olivier.matz@6wind.com \
    --cc=reshma.pattan@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).