From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shachar Beiser <shacharbe@mellanox.com>, dev@dpdk.org
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v7] net/mlx5: support upstream rdma-core
Date: Wed, 20 Sep 2017 16:48:07 +0100 [thread overview]
Message-ID: <15647cd5-aa4b-cf80-97cc-36303dced36b@intel.com> (raw)
In-Reply-To: <0c4ff3cb5a1608e9c2b5717ea3d31e315bb3a6c8.1505744936.git.shacharbe@mellanox.com>
On 9/18/2017 3:49 PM, Shachar Beiser wrote:
> This removes the dependency on specific Mellanox OFED libraries by
> using the upstream rdma-core and linux upstream community code.
> Both rdma-core upstream and Mellanox OFED are Linux user-space packages:
> 1. Rdma-core is Linux upstream user-space package.(Generic)
> 2. Mellanox OFED is Mellanox's Linux user-space package.(Proprietary)
> The difference between the two are the APIs towards the kernel.
>
> ---
> a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202")
> b. Tested with linux kernel 4.13-rc4
> c. For performance testing recommended to wait till kernel 4.14
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
Can you please move sign off above comment (---)
> ---
>
> Rebase on top of series:
> http://dpdk.org/dev/patchwork/patch/28804/
> http://dpdk.org/dev/patchwork/patch/28805/
> This patch should be applied on top of :
> http://dpdk.org/dev/patchwork/patch/28805/
>
> This patch enhances the commit log of the previous patch:
> http://dpdk.org/dev/patchwork/patch/28803/
> An update to the release notes will be sent saperately by Shahaf
> Shuler.
> ---
Hi Shachar,
I can finally able to compile this via rdma-core v15 (Thanks to Nelio),
since I don't have Mellanox OFED 4.2
1- Shared library build fails. mlx5 driver now depends on libmlx5.so,
this dependency should be added [1], otherwise giving build error [2].
2- 32bit build broken, this is because rdma-core 32bit missing.
a) Is rdma-core supports 32bit?
b) Is mlx5 supports 32bit?
3- I am getting ICC warning from rdma-core header [3], same warning many
times. Would you mind disabling that warning for mlx5 [4] ?
[1]
+++ b/drivers/net/mlx5/Makefile
@@ -63,7 +63,7 @@ CFLAGS += -D_DEFAULT_SOURCE
CFLAGS += -D_XOPEN_SOURCE=600
CFLAGS += $(WERROR_FLAGS)
CFLAGS += -Wno-strict-prototypes
-LDLIBS += -libverbs
+LDLIBS += -libverbs -lmlx5
[2]
../drivers/net/mlx5/mlx5.c:542: undefined reference to `mlx5dv_query_device'
mlx5_rxq.o: In function `rxq_setup':
../drivers/net/mlx5/mlx5_rxq.c:803: undefined reference to `mlx5dv_init_obj'
mlx5_txq.o: In function `txq_setup':
../drivers/net/mlx5/mlx5_txq.c:175: undefined reference to `mlx5dv_init_obj'
[3]
In file included from ../drivers/net/mlx5/mlx5.c(48):
/root/development/rdma-core/build/include/infiniband/verbs.h(84):
warning #61: integer operation result is out of range
static void *__VERBS_ABI_IS_EXTENDED = ((uint8_t *) NULL) - 1;
^
[4]
+++ b/drivers/net/mlx5/Makefile
@@ -77,6 +77,11 @@ ifeq ($(DEBUG),1
+ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
+# For rdma-core v15 headers
+CFLAGS += -wd61
+endif
<...>
next prev parent reply other threads:[~2017-09-20 15:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 12:23 [dpdk-dev] [PATCH v1] " Shachar Beiser
2017-08-24 13:43 ` Ferruh Yigit
2017-08-24 14:59 ` Nélio Laranjeiro
[not found] ` <CGME20170831161745eucas1p112753dbc96b3b209d303b007dda0408b@eucas1p1.samsung.com>
2017-08-31 16:17 ` Alexey Perevalov
2017-09-04 6:30 ` Shachar Beiser
2017-09-04 12:07 ` [dpdk-dev] [PATCH v2] " Shachar Beiser
2017-09-04 14:42 ` Nélio Laranjeiro
2017-09-05 13:19 ` [dpdk-dev] [PATCH v3] " Shachar Beiser
2017-09-05 13:44 ` Nélio Laranjeiro
2017-09-07 12:55 ` [dpdk-dev] [PATCH v4] " Shachar Beiser
2017-09-07 14:55 ` Nélio Laranjeiro
2017-09-14 13:34 ` [dpdk-dev] [PATCH v5] " Shachar Beiser
2017-09-14 13:47 ` Ferruh Yigit
2017-09-17 7:31 ` Shachar Beiser
2017-09-18 8:52 ` Shahaf Shuler
2017-09-18 9:07 ` Ferruh Yigit
2017-09-18 13:43 ` Shachar Beiser
2017-09-18 16:04 ` Yigit, Ferruh
2017-09-17 10:10 ` [dpdk-dev] [PATCH v6] " Shachar Beiser
2017-09-18 13:53 ` [dpdk-dev] [PATCH v7] " Shachar Beiser
2017-09-18 14:49 ` Shachar Beiser
2017-09-20 12:23 ` Nélio Laranjeiro
2017-09-20 15:48 ` Ferruh Yigit [this message]
2017-09-26 15:38 ` [dpdk-dev] [PATCH v8] " Nelio Laranjeiro
2017-09-28 15:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15647cd5-aa4b-cf80-97cc-36303dced36b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shacharbe@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).