From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags
Date: Thu, 11 Jan 2018 18:54:23 +0100 [thread overview]
Message-ID: <1566328.PjHp2kMIxd@xps> (raw)
In-Reply-To: <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com>
10/01/2018 07:46, Hemant Agrawal:
> On 1/9/2018 9:00 PM, Ferruh Yigit wrote:
> > On 1/9/2018 3:24 PM, Thomas Monjalon wrote:
> >> 09/01/2018 16:12, Ferruh Yigit:
> >>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> >>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> >>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */
> >>> +/*
> >>> + * Copyright(c) 2007-2014 Intel Corporation.
> >>> */
> >>
> >>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> >>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> >>> +// SPDX-License-Identifier: GPL-2.0
> >>> +/*
> >>> + * Copyright(c) 2010-2014 Intel Corporation.
> >>> */
> >>
> >> Why these empty lines between SPDX and Copyright?
> >
> > For kernel module files I followed Linux style, as "//" comments in .c files.
> > I don't have strong opinion about this...
> >
> >
> I think it is just fine to use the Linux style for kernel module based
> code.
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied, thanks
prev parent reply other threads:[~2018-01-11 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 21:07 [dpdk-dev] [PATCH 1/2] " Ferruh Yigit
2017-12-18 21:07 ` [dpdk-dev] [PATCH 2/2] net/kni: " Ferruh Yigit
2017-12-19 0:05 ` [dpdk-dev] [PATCH v2 1/2] kni: " Ferruh Yigit
2017-12-19 0:05 ` [dpdk-dev] [PATCH v2 2/2] net/kni: " Ferruh Yigit
2018-01-05 11:00 ` [dpdk-dev] [PATCH v2 1/2] kni: " Thomas Monjalon
2018-01-09 15:12 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-01-09 15:24 ` Thomas Monjalon
2018-01-09 15:30 ` Ferruh Yigit
2018-01-10 6:46 ` Hemant Agrawal
2018-01-11 17:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566328.PjHp2kMIxd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).