From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
dev@dpdk.org, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Liu, Yu Y" <yu.y.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset
Date: Fri, 21 Apr 2017 10:27:49 +0200 [thread overview]
Message-ID: <1581788.2CBIGuQB5e@xps> (raw)
In-Reply-To: <20170421022747.GA11512@yliu-dev.sh.intel.com>
21/04/2017 04:27, Yuanhan Liu:
> On Thu, Apr 20, 2017 at 09:17:24AM +0000, Zhao1, Wei wrote:
> > > > > Please explain exactly the responsibility of this function, and how
> > > > > it is different from calling stop/configure/start.
> > > >
> > > > In this reset feature, reset function can do the calling
> > > > stop/configure/start process, but also It can also do some restore
> > > > work for the port, for example, it can restore the added parameters
> > > > of
> > >
> > > vlan, mac_addrs, promisc_unicast_enabled falg and
> > > promisc_multicast_enabled flag.
> > >
> > > > Maybe , I should add this explanation in the patch comments or
> > > > function
> > >
> > > comments?
> > >
> > > I'm curious why we have to do save & restore for a reset operation.
> > > Why some configures have to be saved and restored? Doesn't "reset"
> > > literally means reset everything?
> >
> > Users maybe do not want to do a second configuration operation to waste
> > time after reset which lost all previous configuration. But he still want
> > these configuration valid after reset.
> > So, save & restore can help them to save this process time and effort.
> >
> > > Even though, how do you tell what kind of configures need be restored
> > > and
> > > what should not? Again, even though, will all PMDs supports restoring
> > > the
> > > same set of configurations?
> >
> > Yes, this is hard to say what may be need and what may be not for user.
> > Now, the kinds of supported is list in patch set comment. And only i40e
> > NIC support this feature.
> Why it's the configurations listed in patch 2? Because they are requested
> by customers?
>
> Is that all could be saved? If not, are you going to save & restore all
> possible configurations?
>
> Assuming the configurations saved & restored may differ from different
> PMD drivers, how could you keep the consistency then? And judging that the
> application has no idea about the difference (yet it knows nothing about
> what kind of configurations will be saved), how could the application know
> that some configurations are not saved & restored by the driver that it
> has to do re-configuration by itself?
>
> > > While looking at your reset implementation for i40e, it looks more
> > > complex
> > > than necessary: just thinking we have to call "xxx_queue_setup"
> > > for all PMDs.
> > >
> > > I'm thinking a simple hardware reset might be enough?
> > >
> > > /* literally reset the hardware: reset everything */
> > > rte_eth_reset(port)
> > > {
> > >
> > > eth_dev->ops->reset();
> > >
> > > }
> >
> > You mean just do a reset and do not restore any configuration?
> > That may not meet the need for this feature from customer?
>
> Right, I'm just aware of the configuration might be done by PF (but not
> only by the application), that the VF port may be not aware of those
> configurations. So the save & restore is needed. I don't quite like
> how it is done in this patch set though. I also don't think the API is
> well named: as said, reset should literally reset everything.
>
> We may need think how to do it properly.
>
> Thomas, Konstantin, what do you guys think of it?
I have the same concerns.
I think we should better document the current status of start/stop
and which configuration parameters are lost or saved.
next prev parent reply other threads:[~2017-04-21 8:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:34 [dpdk-dev] [PATCH v4 0/3] net/i40e: vf " Wei Zhao
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for " Wei Zhao
2017-03-30 19:55 ` Thomas Monjalon
2017-04-06 2:57 ` Zhao1, Wei
2017-04-06 7:11 ` Thomas Monjalon
2017-04-06 8:53 ` Zhao1, Wei
2017-04-06 9:02 ` Ananyev, Konstantin
2017-04-10 20:58 ` Thomas Monjalon
2017-04-13 8:55 ` Zhao1, Wei
2017-04-13 10:06 ` Thomas Monjalon
2017-04-14 1:29 ` Zhao1, Wei
2017-04-14 6:31 ` Thomas Monjalon
2017-04-14 8:03 ` Zhao1, Wei
2017-04-17 2:08 ` Zhao1, Wei
2017-04-17 5:02 ` Zhao1, Wei
2017-04-20 6:07 ` Yuanhan Liu
2017-04-20 9:17 ` Zhao1, Wei
2017-04-21 2:27 ` Yuanhan Liu
2017-04-21 8:27 ` Thomas Monjalon [this message]
2017-04-21 8:59 ` Zhao1, Wei
2017-04-21 9:28 ` Thomas Monjalon
2017-04-24 2:01 ` Yuanhan Liu
2017-04-24 3:15 ` Zhao1, Wei
2017-04-24 3:39 ` Zhao1, Wei
2017-04-24 8:04 ` Thomas Monjalon
2017-04-25 3:14 ` Zhao1, Wei
2017-04-21 8:55 ` Zhao1, Wei
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 2/3] net/i40e: implement device reset on port Wei Zhao
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-03-30 12:32 ` [dpdk-dev] [PATCH v4 0/3] net/i40e: vf port reset Wu, Jingjing
2017-04-05 5:42 ` Zhao1, Wei
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 " Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 0/3] net/i40e: vf port reset Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-07 6:58 ` Yang, Qiming
2017-04-10 2:21 ` Zhao1, Wei
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 0/3] net/i40e: vf port reset Wei Zhao
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-20 20:49 ` Thomas Monjalon
2017-04-21 3:20 ` Zhao1, Wei
2017-04-20 20:52 ` Thomas Monjalon
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-20 21:12 ` Thomas Monjalon
2017-04-21 3:39 ` Zhao1, Wei
2017-04-20 21:20 ` Thomas Monjalon
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-20 21:37 ` [dpdk-dev] [PATCH v7 0/3] net/i40e: vf port reset Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-03-30 9:21 [dpdk-dev] [PATCH v4 " Wei Zhao
2017-03-30 9:21 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for " Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581788.2CBIGuQB5e@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yu.y.liu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).