From: Thomas Monjalon <thomas@monjalon.net>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/7] fix DMA mask check
Date: Mon, 05 Nov 2018 01:03:14 +0100 [thread overview]
Message-ID: <1581850.6WJm0uvOED@xps> (raw)
In-Reply-To: <925cecc0-503d-324d-3634-2ec0857ccffc@intel.com>
02/11/2018 19:38, Ferruh Yigit:
> On 11/1/2018 7:53 PM, Alejandro Lucero wrote:
> > A patchset sent introducing DMA mask checks has several critical
> > issues precluding apps to execute. The patchset was reviewed and
> > finally accepted after three versions. Obviously it did not go
> > through the proper testing what can be explained, at least from my
> > side, due to the big changes to the memory initialization code these
> > last months. It turns out the patchset did work with legacy memory
> > and I'm afraid that was mainly my testing.
> >
> > This patchset should solve the main problems reported:
> >
> > - deadlock duriing initialization
> > - segmentation fault with secondary processes
> >
> > For solving the deadlock, a new API is introduced:
> >
> > rte_mem_check_dma_mask_safe/unsafe
> >
> > making the previous rte_mem_check_dma_mask the one those new functions
> > end calling. A boolean param is used for calling rte_memseg_walk thread
> > safe or thread unsafe. This second option is needed for avoiding the
> > deadlock.
> >
> > For the secondary processes problem, the call to check the dma mask is
> > avoided from code being executed before the memory initialization.
> > Instead, a new API function, rte_mem_set_dma_mask is introduced, which
> > will be used in those cases. The dma mask check is done once the memory
> > initialization is completed.
> >
> > This last change implies the IOVA mode can not be set depending on IOMMU
> > hardware limitations, and it is assumed IOVA VA is possible. If the dma
> > mask check reports a problem after memory initilization, the error
> > message includes now advice for trying with --iova-mode option set to
> > pa.
> >
> > The patchet also includes the dma mask check for legacy memory and the
> > no hugepage option.
> >
> > Finally, all the DMA mask API has been updated for using the same prefix
> > than other EAL memory code.
> >
> > An initial version of this patchset has been tested by Intel DPDK
> > Validation team and it seems it solves all the problems reported. This
> > final patchset has the same functionality with minor changes. I have
> > successfully tested the patchset with my limited testbench.
> >
> > v2:
> > - modify error messages with more descriptive information
> > - change safe/unsafe versions for dma check to previous one plus a
> > thread_unsafe version.
> > - use rte_eal_using_phys_addr instead of getuid
> > - fix comments
> > - reorder patches
> >
> > Alejandro Lucero (7):
> > mem: fix call to DMA mask check
> > mem: use proper prefix
> > mem: add function for setting DMA mask
> > bus/pci: avoid call to DMA mask check
> > mem: modify error message for DMA mask check
> > eal/mem: use DMA mask check for legacy memory
> > mem: add thread unsafe version for checking DMA mask
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Fixing the deadlock issue, and build/per-patch build is good.
Applied, thanks
prev parent reply other threads:[~2018-11-05 0:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 19:53 Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 1/7] mem: fix call to " Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 2/7] mem: use proper prefix Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 3/7] mem: add function for setting DMA mask Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 4/7] bus/pci: avoid call to DMA mask check Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 5/7] mem: modify error message for " Alejandro Lucero
2018-11-05 10:01 ` Li, WenjieX A
2018-11-05 10:13 ` Alejandro Lucero
2018-11-05 15:12 ` Burakov, Anatoly
2018-11-05 15:33 ` Alejandro Lucero
2018-11-05 16:34 ` Burakov, Anatoly
2018-11-06 9:32 ` Alejandro Lucero
2018-11-06 10:31 ` Burakov, Anatoly
2018-11-06 10:37 ` Alejandro Lucero
2018-11-06 10:48 ` Burakov, Anatoly
2018-11-06 12:55 ` Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 6/7] eal/mem: use DMA mask check for legacy memory Alejandro Lucero
2018-11-01 19:53 ` [dpdk-dev] [PATCH v2 7/7] mem: add thread unsafe version for checking DMA mask Alejandro Lucero
2018-11-02 18:38 ` [dpdk-dev] [PATCH v2 0/7] fix DMA mask check Ferruh Yigit
2018-11-05 0:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581850.6WJm0uvOED@xps \
--to=thomas@monjalon.net \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).