From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <dev@dpdk.org>
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>, <stable@dpdk.org>
Subject: [dpdk-stable] [PATCH 3/5] net/sfc/base: reject automatic filter creation by users
Date: Tue, 10 Mar 2020 09:48:37 +0000 [thread overview]
Message-ID: <1583833719-6597-4-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1583833719-6597-1-git-send-email-arybchenko@solarflare.com>
From: Igor Romanov <igor.romanov@oktetlabs.ru>
The automatic filter priority may only be used by filter implementation,
so reject the attempts to create such filters by client drivers.
Fixes: f9565517ff4f ("net/sfc/base: import filters support")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_filter.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/sfc/base/efx_filter.c b/drivers/net/sfc/base/efx_filter.c
index 575f6228b..36332a280 100644
--- a/drivers/net/sfc/base/efx_filter.c
+++ b/drivers/net/sfc/base/efx_filter.c
@@ -93,8 +93,15 @@ efx_filter_insert(
goto fail2;
}
+ if (spec->efs_priority == EFX_FILTER_PRI_AUTO) {
+ rc = EINVAL;
+ goto fail3;
+ }
+
return (efop->efo_add(enp, spec, B_FALSE));
+fail3:
+ EFSYS_PROBE(fail3);
fail2:
EFSYS_PROBE(fail2);
fail1:
--
2.17.1
next prev parent reply other threads:[~2020-03-10 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1583833719-6597-1-git-send-email-arybchenko@solarflare.com>
2020-03-10 9:48 ` [dpdk-stable] [PATCH 1/5] net/sfc: set priority of created filters to manual Andrew Rybchenko
2020-03-10 9:48 ` [dpdk-stable] [PATCH 2/5] net/sfc/base: reduce filter priorities to implemented only Andrew Rybchenko
2020-03-10 9:48 ` Andrew Rybchenko [this message]
2020-03-10 9:48 ` [dpdk-stable] [PATCH 4/5] net/sfc/base: refactor filter lookup loop in EF10 Andrew Rybchenko
2020-03-10 9:48 ` [dpdk-stable] [PATCH 5/5] net/sfc/base: handle manual and auto filter clashes " Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583833719-6597-4-git-send-email-arybchenko@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=igor.romanov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).