From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net
Date: Thu, 18 Feb 2016 20:26:32 +0100 [thread overview]
Message-ID: <1593893.DkKoCMf5f8@xps13> (raw)
In-Reply-To: <20160218132549.GN21426@yliu-dev.sh.intel.com>
2016-02-18 21:25, Yuanhan Liu:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> > Commit d0cf91303d73 added dependency on librte_net headers to vhost
> > but did not add this to the Makefile, which makes builds
> > non-deterministic. Curiously it is non-parallel build that is
> > consistently broken by this missing dependency, usually it's the other
> > way around, but trying to build without -j(n) fails with:
>
> Yeah, I have confirmed it; I was wondering why I didn't meet such build
> error.
>
> >
> > dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> > fatal error: rte_ip.h: No such file or directory
> >
> > Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Applied, thanks
prev parent reply other threads:[~2016-02-18 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 9:47 Panu Matilainen
2016-02-18 13:25 ` Yuanhan Liu
2016-02-18 13:39 ` Panu Matilainen
2016-02-18 13:56 ` Yuanhan Liu
2016-02-18 14:07 ` Panu Matilainen
2016-02-19 1:56 ` Yuanhan Liu
2016-02-19 10:24 ` Thomas Monjalon
2016-02-23 15:34 ` Bruce Richardson
2016-02-18 19:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593893.DkKoCMf5f8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).