From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] e1000/base: fix the wrong assignment to msgbuf[0]
Date: Tue, 14 Feb 2017 09:50:27 +0100 [thread overview]
Message-ID: <1597373.SEVY7yqftY@xps13> (raw)
In-Reply-To: <1487063647-16263-1-git-send-email-wang.yong19@zte.com.cn>
2017-02-14 04:14, Yong Wang:
> In function e1000_update_mc_addr_list_vf(), "msgbuf[0]" is used prior
> to initialization at "msgbuf[0] |= E1000_VF_SET_MULTICAST_OVERFLOW".
> And "msgbuf[0]" is overwritten at "msgbuf[0] = E1000_VF_SET_MULTICAST".
> Fix it by moving the second line prior to the first one that mentioned
> above.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Note about the title: msgbuf[0] does not explain anything in the title
because we have no context when browsing the titles.
It could be "e1000/base: fix multicast setting in VF".
prev parent reply other threads:[~2017-02-14 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:14 Yong Wang
2017-02-14 8:24 ` Lu, Wenzhuo
2017-02-14 8:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597373.SEVY7yqftY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).