DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
	dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v2 07/16] test/bbdev: test start/stop bbdev API
Date: Mon, 20 Feb 2023 21:21:08 +0100	[thread overview]
Message-ID: <15ada1b5-4be5-ca0c-092c-e830bf1f1b4b@redhat.com> (raw)
In-Reply-To: <20230215170949.60569-8-hernan.vargas@intel.com>



On 2/15/23 18:09, Hernan Vargas wrote:
> Add a call to queue start and queue stop specifically for testing the
> bbdev API.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 057fb5ac9e..e4eb71050a 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -890,6 +890,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
>   			ret = rte_bbdev_queue_configure(ad->dev_id, queue_id,
>   					&qconf);
>   		}
> +		rte_bbdev_queue_start(ad->dev_id, queue_id);

You may want to check the return value, that would be useful since the
goal is to test the API.

>   		if (ret != 0) {
>   			printf("All queues on dev %u allocated: %u\n",
>   					dev_id, queue_id);
> @@ -898,8 +899,8 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
>   		ad->queue_ids[queue_id] = queue_id;
>   	}
>   	TEST_ASSERT(queue_id != 0,
> -			"ERROR Failed to configure any queues on dev %u",
> -			dev_id);
> +			"ERROR Failed to configure any queues on dev %u\n"
> +			"\tthe device may not support or have been configured", dev_id);
>   	ad->nb_queues = queue_id;
>   
>   	set_avail_op(ad, op_type);
> @@ -3846,6 +3847,7 @@ throughput_pmd_lcore_ldpc_dec(void *arg)
>   		TEST_ASSERT_SUCCESS(ret, "Validation failed!");
>   	}
>   
> +	rte_bbdev_queue_stop(tp->dev_id, queue_id);

Ditto.

>   	rte_bbdev_dec_op_free_bulk(ops_enq, num_ops);
>   
>   	double tb_len_bits = calc_ldpc_dec_TB_size(ref_op);


  reply	other threads:[~2023-02-20 20:21 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 17:09 [PATCH v2 00/16] test/bbdev: changes for 23.03 Hernan Vargas
2023-02-15 17:09 ` [PATCH v2 01/16] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-02-20 16:08   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 02/16] test/bbdev: extend HARQ tolerance Hernan Vargas
2023-02-20 16:09   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 03/16] test/bbdev: refactor TB throughput report Hernan Vargas
2023-02-20 16:10   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 04/16] test/bbdev: add timeout for latency tests Hernan Vargas
2023-02-20 16:32   ` Maxime Coquelin
2023-02-22 21:13     ` Vargas, Hernan
2023-02-23  8:31       ` Maxime Coquelin
2023-02-24 16:59         ` Vargas, Hernan
2023-02-27  9:44           ` Maxime Coquelin
2023-02-28 22:37             ` Chautru, Nicolas
2023-03-02 10:12               ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 05/16] test/bbdev: enable early termination for validation Hernan Vargas
2023-02-20 20:12   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 06/16] test/bbdev: report device status in test-bbdev Hernan Vargas
2023-02-20 20:17   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 07/16] test/bbdev: test start/stop bbdev API Hernan Vargas
2023-02-20 20:21   ` Maxime Coquelin [this message]
2023-02-15 17:09 ` [PATCH v2 08/16] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-02-22 10:48   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 09/16] test/bbdev: extend support for large TB Hernan Vargas
2023-02-22 10:49   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 10/16] test/bbdev: adjustment for soft output Hernan Vargas
2023-02-22 10:50   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 11/16] test/bbdev: expose warning counters Hernan Vargas
2023-02-22 10:52   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 12/16] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-02-22 10:53   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 13/16] test/bbdev: remove iteration count check Hernan Vargas
2023-02-22 10:55   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 14/16] test/bbdev: use mbuf reset function Hernan Vargas
2023-02-22 10:56   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 15/16] test/bbdev: remove max iteration from vectors Hernan Vargas
2023-02-22 10:58   ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 16/16] test/bbdev: remove iter count from bler test Hernan Vargas
2023-02-22 11:01   ` Maxime Coquelin
2023-02-20 15:31 ` [PATCH v2 00/16] test/bbdev: changes for 23.03 Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15ada1b5-4be5-ca0c-092c-e830bf1f1b4b@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hernan.vargas@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).