From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <chas3@att.com>,
<declan.doherty@intel.com>, <bernard.iremonger@intel.com>
Subject: [dpdk-dev] [PATCH V2] bonding: fix xmit balance policy name
Date: Tue, 20 Oct 2020 11:04:16 +0800 [thread overview]
Message-ID: <1603163056-9961-1-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1603162632-6637-1-git-send-email-humin29@huawei.com>
Currently there exits inconsistence about name of transmission
policy for a Link Bonding device. "xmit_balance_policy" is not
correct, which should be modified to "balance_xmit_policy".
Fixes: 2950a769315e ("bond: testpmd support")
Fixes: ac718398f477 ("doc: testpmd application user guide")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v1->v2:
fix commit log info.
---
app/test-pmd/cmdline.c | 2 +-
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 07ee4e4..9bc7751 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -649,7 +649,7 @@ static void cmd_help_long_parsed(void *parsed_result,
"set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)"
" Set Aggregation mode for IEEE802.3AD (mode 4)"
- "set bonding xmit_balance_policy (port_id) (l2|l23|l34)\n"
+ "set bonding balance_xmit_policy (port_id) (l2|l23|l34)\n"
" Set the transmit balance policy for bonded device running in balance mode.\n\n"
"set bonding mon_period (port_id) (value)\n"
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index a4c07c9..3f8719e 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -2610,16 +2610,16 @@ For example, to set the MAC address of a Link Bonding device (port 10) to 00:00:
testpmd> set bonding mac 10 00:00:00:00:00:01
-set bonding xmit_balance_policy
+set bonding balance_xmit_policy
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Set the transmission policy for a Link Bonding device when it is in Balance XOR mode::
- testpmd> set bonding xmit_balance_policy (port_id) (l2|l23|l34)
+ testpmd> set bonding balance_xmit_policy (port_id) (l2|l23|l34)
For example, set a Link Bonding device (port 10) to use a balance policy of layer 3+4 (IP addresses & UDP ports)::
- testpmd> set bonding xmit_balance_policy 10 l34
+ testpmd> set bonding balance_xmit_policy 10 l34
set bonding mon_period
--
2.7.4
next prev parent reply other threads:[~2020-10-20 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 2:57 [dpdk-dev] [PATCH] " Min Hu (Connor)
2020-10-20 3:04 ` Min Hu (Connor) [this message]
2020-10-20 16:19 ` [dpdk-dev] [PATCH V2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603163056-9961-1-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=bernard.iremonger@intel.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).