From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, matvejchikov@gmail.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo
Date: Tue, 17 Jan 2017 18:22:29 +0100 [thread overview]
Message-ID: <1606457.4zG12SYGZt@xps13> (raw)
In-Reply-To: <18c98c3f-f104-f9a6-f043-5c0421542c51@intel.com>
2016-11-23 15:43, Ferruh Yigit:
> On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> > Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > ---
> > examples/ip_pipeline/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> > index 5827117..6657237 100644
> > --- a/examples/ip_pipeline/Makefile
> > +++ b/examples/ip_pipeline/Makefile
> > @@ -36,7 +36,7 @@ endif
> > # Default target, can be overridden by command line or environment
> > RTE_TARGET ?= x86_64-native-linuxapp-gcc
> >
> > -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> > +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
>
> No need to fix, this line can be removed completely.
>
> Because of:
> VPATH += $(SRCDIR)/pipeline
>
> and files handled in this makefile:
> SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c
>
> When you fix DIR-y, you also need to add a makefile to pipeline folder
> and update this makefile. I guess all those are not required. Just
> removing that line is easier J
There was no progress on this trivial patch.
So I made what Ferruh suggested and applied in the tree directly:
http://dpdk.org/commit/45e1c8b
Thanks for the report and the review.
prev parent reply other threads:[~2017-01-17 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 12:56 Ilya Matveychikov
2016-11-23 15:43 ` Ferruh Yigit
2017-01-17 17:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606457.4zG12SYGZt@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).