From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported
Date: Tue, 04 Apr 2017 16:01:30 +0200 [thread overview]
Message-ID: <1610139.QdKl0Sncku@xps13> (raw)
In-Reply-To: <f7td1cs70ly.fsf@redhat.com>
2017-04-04 09:39, Aaron Conole:
> Hi Thomas,
>
> Thomas Monjalon <thomas.monjalon@6wind.com> writes:
>
> > 2017-03-31 14:31, Aaron Conole:
> >> It's likely that this function isn't used anywhere, but since it was part of
> >> the public API, mark the function for deprecation for at least one release.
> >>
> >> Signed-off-by: Aaron Conole <aconole@redhat.com>
>
> Thanks so much for the review! I'll make sure to fix these with v2.
>
> > [...]
> >> +DPDK_17.05 {
> >> + global;
> >> +
> >> + rte_cpu_is_supported;
> >> +
> >> +} DPDK_17.02;
> >
> > Should not it be a separate patch?
>
> I thought it made sense to keep it rolled in with this patch, but if you
> prefer it separate, I will do that. Expect it as 1/2 in v2, unless you
> say otherwise.
Yes 2 patches in v2. Thanks
next prev parent reply other threads:[~2017-04-04 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 18:31 Aaron Conole
2017-04-03 8:55 ` Bruce Richardson
2017-04-04 13:26 ` Thomas Monjalon
2017-04-04 13:39 ` Aaron Conole
2017-04-04 14:01 ` Thomas Monjalon [this message]
2017-04-04 15:38 ` [dpdk-dev] [PATCH 1/2] eal: add rte_cpu_is_supported to map Aaron Conole
2017-04-04 15:38 ` [dpdk-dev] [PATCH 2/2] eal: deprecate rte_cpu_check_supported Aaron Conole
2017-04-06 20:58 ` [dpdk-dev] [PATCH 1/2] eal: add rte_cpu_is_supported to map Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610139.QdKl0Sncku@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).