patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: keith.wiles@intel.com, Yongseok Koh <yskoh@mellanox.com>,
	ferruh.yigit@intel.com
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	Shahaf Shuler <shahafs@mellanox.com>,
	konstantin.ananyev@intel.com, anatoly.burakov@intel.com,
	stable@dpdk.org, justin.parus@microsoft.com,
	christian.ehrhardt@canonical.com, david.coronel@canonical.com,
	josh.powers@canonical.com, jay.vosburgh@canonical.com,
	dan.streetman@canonical.com
Subject: Re: [dpdk-stable] AVX512 bug on SkyLake
Date: Thu, 08 Nov 2018 16:59:22 +0100	[thread overview]
Message-ID: <1612642.At0RDolh7h@xps> (raw)
In-Reply-To: <432F92CE-5714-45DC-B72F-CD8771DAFC89@intel.com>

Hi,

We need to gather more information about this bug.
More below.

07/11/2018 10:04, Wiles, Keith:
> > On Nov 6, 2018, at 9:30 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> >> On Nov 5, 2018, at 6:06 AM, Wiles, Keith <keith.wiles@intel.com> wrote:
> >>> On Nov 2, 2018, at 9:04 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> >>> 
> >>> This is a workaround to prevent a crash, which might be caused by
> >>> optimization of newer gcc (7.3.0) on Intel Skylake.
> >> 
> >> Should the code below not also test for the gcc version and
> >> the Sky Lake processor, maybe I am wrong but it seems it is
> >> turning AVX512 for all GCC builds
> > 
> > I didn't want to check gcc version as 7.3.0 is very new. Only gcc 8 is newly up since then (gcc 8.2).
> > Also, I wasn't able to test every gcc versions and I wanted to be a bit conservative for this crash.
> > Performance drop (if any) by disabling a new (experimental) feature would be less risky than unaccountable crash.
> > And, it does disable the feature only if CONFIG_RTE_ENABLE_AVX512=n. Please refer to v3.
> 
> Are you not turning off all of the GCC versions for AVX512.
> And you can test for range or greater then GCC version and
> it just seems like we are turning off every gcc version, is that true?

Do we know exactly which GCC versions are affected?

> >> Also bug 97 seems a bit obscure reference, maybe you know
> >> the bug report, but more details would be good?
> > 
> > I sent out the report to dev list two month ago.
> > And I created the Bug 97 in order to reference it
> > in the commit message.
> > I didn't want to repeat same message here and there,
> > but it would've been better to have some sort of summary
> > of the Bug, although v3 has a few more words.
> > However, v3 has been merged.
> 
> Still this is too obscure if nothing else give a link to
> a specific bug not just 97.

The URL is
	https://bugs.dpdk.org/show_bug.cgi?id=97
The bug is also pointing to an email:
	https://mails.dpdk.org/archives/dev/2018-September/111522.html

Summary:
	- CPU: Intel Skylake
	- Linux environment: Ubuntu 18.04
	- Compiler: gcc-7.3 (Ubuntu 7.3.0-16ubuntu3)
	- Scenario: testpmd crashes when it starts forwarding
	- Behaviour: AVX2 version of rte_memcpy() optimized with 512b instructions
	- Fix: disable AVX512 optimization with -mno-avx512f

It seems to have been reproduced only when using mlx5 PMD so far.
Any other experience?

  reply	other threads:[~2018-11-08 15:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 21:23 [dpdk-stable] [PATCH] build: disable compiler AVX512F support Yongseok Koh
2018-11-01 23:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-11-02 12:42 ` [dpdk-stable] " Ferruh Yigit
2018-11-02 13:48   ` Ferruh Yigit
2018-11-02 20:59     ` Yongseok Koh
2018-11-02 21:46       ` Ferruh Yigit
2018-11-02 23:31         ` Yongseok Koh
2018-11-02 21:04 ` [dpdk-stable] [PATCH v2] " Yongseok Koh
2018-11-05 14:06   ` [dpdk-stable] [dpdk-dev] " Wiles, Keith
2018-11-06 21:30     ` Yongseok Koh
2018-11-07  9:04       ` Wiles, Keith
2018-11-08 15:59         ` Thomas Monjalon [this message]
2018-11-08 17:21           ` [dpdk-stable] AVX512 bug on SkyLake Ferruh Yigit
2018-11-08 23:01             ` Yongseok Koh
2018-11-09  6:27               ` Christian Ehrhardt
2018-11-09  9:49                 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2018-11-09 11:35                   ` Thomas Monjalon
2018-11-09 10:03               ` [dpdk-stable] " Ferruh Yigit
2018-11-09 13:17                 ` Thomas Monjalon
2018-11-09 14:27                   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-11-09 20:06                     ` Ferruh Yigit
2018-11-09 18:46           ` Stephen Hemminger
2018-11-10  2:13           ` [dpdk-stable] " Thomas Monjalon
2018-11-11 14:15             ` Ananyev, Konstantin
2018-11-11 18:15               ` Thomas Monjalon
2018-11-12  9:09                 ` Christian Ehrhardt
2018-11-12  9:21                   ` Thomas Monjalon
2018-11-12  9:26                 ` Ananyev, Konstantin
2018-11-03  1:06 ` [dpdk-stable] [PATCH v3] build: disable gcc AVX512F support Yongseok Koh
2018-11-04 20:56   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612642.At0RDolh7h@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dan.streetman@canonical.com \
    --cc=david.coronel@canonical.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=josh.powers@canonical.com \
    --cc=justin.parus@microsoft.com \
    --cc=keith.wiles@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).