From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 4/6] net/hns3: fix VF setting alive order problem
Date: Fri, 7 May 2021 17:08:17 +0800 [thread overview]
Message-ID: <1620378499-5090-5-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1620378499-5090-1-git-send-email-humin29@huawei.com>
From: HongBo Zheng <zhenghongbo3@huawei.com>
Currently in the VF reset scenario, the VF performs the set
alive operation before restoring the configuration completed,
which may cause the hardware to work in an abnormal state.
This patch fix this problem by set VF alive after restoring
the configuration completed.
Fixes: a5475d61fa34 ("net/hns3: support VF")
Cc: stable@dpdk.org
Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index 71f3f95..536ed46 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -1891,12 +1891,6 @@ hns3vf_init_hardware(struct hns3_adapter *hns)
goto err_init_hardware;
}
- ret = hns3vf_set_alive(hw, true);
- if (ret) {
- PMD_INIT_LOG(ERR, "Failed to VF send alive to PF: %d", ret);
- goto err_init_hardware;
- }
-
return 0;
err_init_hardware:
@@ -1995,6 +1989,12 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
hns3_rss_set_default_args(hw);
+ ret = hns3vf_set_alive(hw, true);
+ if (ret) {
+ PMD_INIT_LOG(ERR, "Failed to VF send alive to PF: %d", ret);
+ goto err_set_tc_queue;
+ }
+
return 0;
err_set_tc_queue:
@@ -2706,6 +2706,13 @@ hns3vf_restore_conf(struct hns3_adapter *hns)
hns3_info(hw, "hns3vf dev restart successful!");
} else if (hw->adapter_state == HNS3_NIC_STOPPING)
hw->adapter_state = HNS3_NIC_CONFIGURED;
+
+ ret = hns3vf_set_alive(hw, true);
+ if (ret) {
+ hns3_err(hw, "failed to VF send alive to PF: %d", ret);
+ goto err_vlan_table;
+ }
+
return 0;
err_vlan_table:
--
2.7.4
next prev parent reply other threads:[~2021-05-07 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:08 [dpdk-dev] [PATCH 0/6] bugfix for hns3 PMD Min Hu (Connor)
2021-05-07 9:08 ` [dpdk-dev] [PATCH 1/6] net/hns3: return code when PCI config space write fail Min Hu (Connor)
2021-05-07 9:08 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix logging info when clear all FDIR rules Min Hu (Connor)
2021-05-07 9:08 ` [dpdk-dev] [PATCH 3/6] net/hns3: clear hash map " Min Hu (Connor)
2021-05-07 9:08 ` Min Hu (Connor) [this message]
2021-05-07 9:08 ` [dpdk-dev] [PATCH 5/6] net/hns3: fix out param not set when query FDIR counter Min Hu (Connor)
2021-05-07 9:08 ` [dpdk-dev] [PATCH 6/6] doc: add link status event pre-conditions Min Hu (Connor)
2021-05-11 16:14 ` Ferruh Yigit
2021-05-12 1:05 ` Min Hu (Connor)
2021-06-30 2:00 ` Min Hu (Connor)
2021-06-30 1:56 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-07-02 8:55 ` Andrew Rybchenko
2021-07-02 12:35 ` Thomas Monjalon
2021-07-02 12:58 ` Andrew Rybchenko
2021-07-04 19:42 ` Thomas Monjalon
2021-05-11 16:30 ` [dpdk-dev] [PATCH 0/6] bugfix for hns3 PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620378499-5090-5-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).