From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org,
"Phil Yang (Arm Technology China)" <Phil.Yang@arm.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/mcslock: wait for lcore completion
Date: Thu, 08 Aug 2019 12:22:00 +0200 [thread overview]
Message-ID: <16315833.7BtyHD5jhk@xps> (raw)
In-Reply-To: <VE1PR08MB464056655B5D6B9E40E1FC31E9D70@VE1PR08MB4640.eurprd08.prod.outlook.com>
08/08/2019 05:44, Phil Yang (Arm Technology China):
> From: Aaron Conole <aconole@redhat.com>
> >
> > It's possible that the mcsunlock occurs before the test_mcslock_try has
> > a chance to execute, which will result in the trylock being successful,
> > making the test case fail. Fix this by waiting until all lcores have
> > completed their test before unlocking the master lock.
> >
> > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test")
> > Cc: Phil Yang <phil.yang@arm.com>
> > Cc: Gavin Hu <gavin.hu@arm.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
>
> Thanks for the patch.
> Acked-by: Phil Yang <phil.yang@arm.com>
Applied, thanks
next prev parent reply other threads:[~2019-08-08 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 14:58 Aaron Conole
2019-08-08 3:44 ` Phil Yang (Arm Technology China)
2019-08-08 10:22 ` Thomas Monjalon [this message]
2019-08-08 6:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16315833.7BtyHD5jhk@xps \
--to=thomas@monjalon.net \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).