DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH 0/2] l2fwd/l3fwd: rework long options parsing
Date: Tue, 17 Jan 2017 18:11:04 +0100	[thread overview]
Message-ID: <1632514.EAEELXtbXD@xps13> (raw)
In-Reply-To: <6f710163-fb03-a3dd-1520-ff78c07d146a@6wind.com>

2016-11-22 14:59, Olivier Matz:
> Hi,
> 
> On 11/22/2016 02:52 PM, Olivier Matz wrote:
> > These 2 patches were part of this RFC, which will not be integrated:
> > http://dpdk.org/ml/archives/dev/2016-September/046974.html
> > 
> > It does not bring any functional change, it just reworks the way long
> > options are parsed in l2fwd and l3fwd to avoid uneeded strcmp() calls
> > and to ease the addition of a new long option in the future.
> > 
> > I send them in case maintainers think it is better this way, but I have
> > no real need.
> > 
> > Olivier Matz (2):
> >   l3fwd: rework long options parsing
> >   l2fwd: rework long options parsing
> > 
> >  examples/l2fwd/main.c |  30 +++++++--
> >  examples/l3fwd/main.c | 169 ++++++++++++++++++++++++++------------------------
> >  2 files changed, 111 insertions(+), 88 deletions(-)
> > 
> 
> Sorry, I missed some checkpatch issues. I'll fix them in v2.
> I'm waiting a bit for other comments, in case of.

There was no comment.
It seems this version is good enough.

Applied with a checkpatch fix, thanks

      reply	other threads:[~2017-01-17 17:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 13:52 Olivier Matz
2016-11-22 13:52 ` [dpdk-dev] [PATCH 1/2] l3fwd: " Olivier Matz
2016-11-22 13:52 ` [dpdk-dev] [PATCH 2/2] l2fwd: " Olivier Matz
2016-11-22 13:59 ` [dpdk-dev] [PATCH 0/2] l2fwd/l3fwd: " Olivier Matz
2017-01-17 17:11   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1632514.EAEELXtbXD@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).