From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: disable NUMA related warnings on non-NUMA systems
Date: Fri, 21 Jul 2017 09:01:05 +0300 [thread overview]
Message-ID: <16337430.qy0lxGFHke@xps> (raw)
In-Reply-To: <1499941699-19478-1-git-send-email-hemant.agrawal@nxp.com>
13/07/2017 13:28, Hemant Agrawal:
> Disabling NUMA warnings on non-NUMA systems.
>
> "EAL: eal_parse_sysfs_value(): cannot open sysfs value
> /sys/bus/pci/devices/0000:00:00.0/numa_node
> EAL: numa_node is invalid or not present. Set it 0 as default
> EAL: cannot open /proc/self/numa_maps, consider that all memory is
> in socket_id 0"
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
If I understand well, you are disabling every warnings when DPDK
is compiled without libnuma.
I think we should keep one warning in case libnuma is not available
but it is running on a NUMA system.
What about adding this kind of sysfs check?
#ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES
if (sysfs/numa_node is present)
RTE_LOG(WARN, "Only the first NUMA node will be used\n");
#endif
next prev parent reply other threads:[~2017-07-21 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 10:28 Hemant Agrawal
2017-07-21 6:01 ` Thomas Monjalon [this message]
2017-07-21 12:14 ` Hemant Agrawal
2017-07-24 9:14 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2017-07-24 9:20 ` [dpdk-dev] [PATCH v3] " Hemant Agrawal
2017-07-24 9:45 ` Jerin Jacob
2017-07-30 21:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16337430.qy0lxGFHke@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).