DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Dan Gora <dg@adax.com>
Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration
Date: Fri, 29 Jun 2018 01:55:54 +0200	[thread overview]
Message-ID: <1639218.dJ5v8slQoU@xps> (raw)
In-Reply-To: <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com>

20/06/2018 19:15, Ferruh Yigit:
> On 6/20/2018 6:07 PM, Dan Gora wrote:
> > Hi Ferruh,
> > 
> > The documentation for rte_eth_dev_configure() should get updated as
> > well to document this requirement to strip the unsupported RSS hash
> > function bits.  The current documentation only refers to the tx/rx
> > offload bits:
> > 
> >  *     -  Any offloading set in eth_conf->[rt]xmode.offloads must be within
> >  *        the [rt]x_offload_capa returned from rte_eth_dev_infos_get().
> >  *        Any type of device supported offloading set in the input argument
> >  *        eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled
> >  *        on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup().
> 
> Agreed, will update the patch according.

I don't see the doc updated in your v2.

  reply	other threads:[~2018-06-28 23:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 15:01 Ferruh Yigit
2018-06-20 15:11 ` Hunt, David
2018-06-20 17:03   ` Dan Gora
2018-06-20 17:07     ` Dan Gora
2018-06-20 17:15       ` Ferruh Yigit
2018-06-28 23:55         ` Thomas Monjalon [this message]
2018-06-29 12:54           ` Ferruh Yigit
2018-06-20 17:15     ` Ferruh Yigit
2018-06-21 16:54 ` Pavan Nikhilesh
2018-06-21 17:16   ` Ferruh Yigit
2018-06-26 17:32 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-06-29 13:54   ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-07-03 16:58     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-07-03 18:08       ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2018-07-04 20:02         ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2018-07-05  8:17           ` Zhao, MeijuanX
2018-07-05  9:30           ` Hunt, David
2018-07-05 13:09             ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1639218.dJ5v8slQoU@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=dg@adax.com \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).