patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: stable@dpdk.org, dev@dpdk.org, didier.pallard@6wind.com,
	hari.kumarx.vemula@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] eal: fix corelist validation with disabled cores
Date: Thu, 07 Mar 2019 21:23:51 +0100	[thread overview]
Message-ID: <1660386.vIg6TEdDp7@xps> (raw)
In-Reply-To: <1550088419-10812-2-git-send-email-david.marchand@redhat.com>

13/02/2019 21:06, David Marchand:
> -l and -c options are two ways to select the cores used by DPDK.
> Their format differs, but the checks on the selected cores are the same.
> Use an intermediate array to separate the specific parsing checks from
> the common consistency checks.
> The parsing functions now concentrate on validating the passed string
> and do nothing more.
> 
> We can report all invalid core indexes rather than only the first error.
> In the error log message, reporting [0, cfg->lcore_count - 1] as a valid
> range is then wrong when the core list is not continuous.
> 
> Example on my 8 cpus laptop with core 2 and 6 disabled.
> echo 0 > /sys/devices/system/cpu/cpu2/online
> echo 0 > /sys/devices/system/cpu/cpu6/online
> 
> Before:
> ./master/app/testpmd -l 0-7 --no-huge -m 512 -- --total-num-mbufs 2048
> EAL: Detected 6 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: invalid core list, please check core numbers are in [0, 5] range
> ...
> 
> After:
> ./master/app/testpmd -l 0-7 --no-huge -m 512 -- --total-num-mbufs 2048
> EAL: Detected 6 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: lcore 2 unavailable
> EAL: lcore 6 unavailable
> EAL: invalid core list, please check specified cores are part of 0-1,3-5,7
> ...
> 
> Fixes: d888cb8b9613 ("eal: add core list input format")
> Fixes: b38693b612b4 ("eal: fix core number validation")
> Signed-off-by: David Marchand <david.marchand@redhat.com>

+Cc: stable@dpdk.org

Applied, thanks

      reply	other threads:[~2019-03-07 20:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 20:06 [dpdk-stable] [PATCH 1/2] eal: remove dead code in corelist parsing David Marchand
2019-02-13 20:06 ` [dpdk-stable] [PATCH 2/2] eal: fix corelist validation with disabled cores David Marchand
2019-03-07 20:23   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1660386.vIg6TEdDp7@xps \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=hari.kumarx.vemula@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).