DPDK CI discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Timothy McDaniel <timothy.mcdaniel@intel.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Ray Kinsella <mdr@ashroe.eu>, Aaron Conole <aconole@redhat.com>,
	dpdklab <dpdklab@iol.unh.edu>,
	"abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
	"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
	dev <dev@dpdk.org>, Shijith Thotton <sthotton@marvell.com>,
	Akhil Goyal <gakhil@marvell.com>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
	ci@dpdk.org
Subject: Re: [dpdk-ci] [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
Date: Tue, 13 Apr 2021 11:01:33 +0200	[thread overview]
Message-ID: <1669547.TGag7vyBUX@thomas> (raw)
In-Reply-To: <CALBAE1O6V+pN0p55_LsYsKiYmqHNk1rfaXuYn-bLgVVpbxruDQ@mail.gmail.com>

13/04/2021 10:54, Jerin Jacob:
> On Tue, Apr 13, 2021 at 12:46 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > > >   http://dpdk.org/git/next/dpdk-next-eventdev
> > >
> > > Pulled, thanks.
> > >
> > > Note few changes in titles like uppercases for acronyms,
> > > or "add support" simplified as "support",
> > > and release notes moved in the right place.
> >
> > The ABI check now reports an error on event/dlb.
> > The reason is that the event/dlb driver has been removed, and so the
> > check complains about a missing dump.
> > This will have to be fixed quickly or reverted.
> >
> >
> > This has been missed by multiple people, so trying to understand why.
> 
> 
> I was running the following script[1] to detect ABI issues.
> Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> the error print was "Error: cannot find librte_event_dlb.dump", It is
> missed from my side.
> 
> @David Marchand  @Thomas Monjalon Could you share the snippet you are
> using for detecting the ABI issue.

I do like you: simply run test-meson-builds.sh
And yes I saw the error, and I don't know why I thought it was OK!
We are humans :)


> ------------------------
> # ABI check
> DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
> ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
> if [ $? -ne 0 ]; then
>         echo "ABI check failed"
>         exit
> fi
> 
> grep "Error: ABI issue reported" /tmp/build.log
> if [ $? -eq 0 ]; then
>         echo "ABI issue"
>         exit
> fi
> 
> -------------------------------------------------------
> >
> > The ABI check should have caught this when run by maintainers (/me
> > looks at Thomas and Jerin).
> 
> Sorry for that :-(




  reply	other threads:[~2021-04-13  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <SN7PR18MB4398B6507C1A0567260158CDC8709@SN7PR18MB4398.namprd18.prod.outlook.com>
     [not found] ` <3565653.Ar8n8QqFrN@thomas>
2021-04-13  7:15   ` David Marchand
2021-04-13  7:31     ` Thomas Monjalon
2021-04-13  8:54     ` Jerin Jacob
2021-04-13  9:01       ` Thomas Monjalon [this message]
2021-04-13  9:07       ` David Marchand
2021-04-13  9:12         ` Thomas Monjalon
2021-04-13  9:14         ` David Marchand
2021-04-13 12:58     ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1669547.TGag7vyBUX@thomas \
    --to=thomas@monjalon.net \
    --cc=abhinandan.gujjar@intel.com \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=gakhil@marvell.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=mdr@ashroe.eu \
    --cc=pbhagavatula@marvell.com \
    --cc=sthotton@marvell.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).